[LTP] [PATCH 18/21] network/lib6/asapi_06: pcmsg->cmsg_len is of type size_t

[LTP] [PATCH 18/21] network/lib6/asapi_06: pcmsg->cmsg_len is of type size_t

[Markos Chandras]

[-- Attachment #1: Type: text/plain, Size: 49 bytes --]

Hi, please review the attached patch

-- 
markos

[-- Attachment #2: 0018-network-lib6-asapi_06-pcmsg-cmsg_len-is-of-type-size.patch --]
[-- Type: text/plain, Size: 1026 bytes --]

From a83368f2077913705a54532b48b1bd3634cc9934 Mon Sep 17 00:00:00 2001
From: Markos Chandras <markos.chandras@imgtec.com>
Date: Thu, 22 Dec 2011 15:10:11 +0000
Subject: [PATCH 18/21] network/lib6/asapi_06: pcmsg->cmsg_len is of type size_t

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
 testcases/network/lib6/asapi_06.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/network/lib6/asapi_06.c b/testcases/network/lib6/asapi_06.c
index 3808c37..6f4428b 100644
--- a/testcases/network/lib6/asapi_06.c
+++ b/testcases/network/lib6/asapi_06.c
@@ -413,7 +413,7 @@ so_test(struct soent *psoe)
 				break;
 			else if (psoe->so_clear) {
 				tst_resm(TFAIL, "%s receive: extraneous data "
-					"in control: level %d type %d len %d",
+					"in control: level %d type %d len %zu",
 					psoe->so_tname, pcmsg->cmsg_level,
 					pcmsg->cmsg_type, pcmsg->cmsg_len);
 				return;
@@ -643,4 +643,4 @@ cleanup(void)
 {
 	TEST_CLEANUP;
 
-}
\ No newline at end of file
+}
-- 
1.7.1


[-- Attachment #3: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 18/21] network/lib6/asapi_06: pcmsg->cmsg_len is of type size_t

[Garrett Cooper]

On Tue, Jan 3, 2012 at 5:23 AM, Markos Chandras
<Markos.Chandras@imgtec.com> wrote:
> Hi, please review the attached patch

    This is ok. While the stance here has been to follow the PRI*
style format string qualifiers, this works and is pseudo standard
across BSD, Linux, and probably a few other printf(3) implementations.
Thanks,
-Garrett

Reviewed-by: Garrett Cooper <yanegomi@gmail.com>

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 18/21] network/lib6/asapi_06: pcmsg->cmsg_len is of type size_t

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 596 bytes --]

On Tuesday 03 January 2012 14:33:05 Garrett Cooper wrote:
> On Tue, Jan 3, 2012 at 5:23 AM, Markos Chandras
> 
> <Markos.Chandras@imgtec.com> wrote:
> > Hi, please review the attached patch
> 
>     This is ok. While the stance here has been to follow the PRI*
> style format string qualifiers, this works and is pseudo standard
> across BSD, Linux, and probably a few other printf(3) implementations.

the PRI* stuff is for explicitly sized types (e.g. 8bit/16bit/32bit/64bit).  it 
is not for [s]size_t types ... that's what the "z" length field of printf is 
designed for.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list