[LTP] [PATCH 01/21] lib/parse_opts: STD_LP_sbrk and STD_start_break should only be defined when UCLINUX=0

[LTP] [PATCH 01/21] lib/parse_opts: STD_LP_sbrk and STD_start_break should only be defined when UCLINUX=0

[Markos Chandras]

[-- Attachment #1: Type: text/plain, Size: 51 bytes --]

Hi,

Please review the attached patch.

-- 
markos

[-- Attachment #2: 0001-lib-parse_opts-STD_LP_sbrk-and-STD_start_break-shoul.patch --]
[-- Type: text/plain, Size: 1178 bytes --]

From 73d72d74229c0598b2e1d5e070418c5855159373 Mon Sep 17 00:00:00 2001
From: Markos Chandras <markos.chandras@imgtec.com>
Date: Thu, 22 Dec 2011 10:36:35 +0000
Subject: [PATCH 01/21] lib/parse_opts: STD_LP_sbrk and STD_start_break should only be defined when UCLINUX=0

These variables are only used when the UCLINUX macro is not defined therefore it
is better to declare them conditionally.

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
 lib/parse_opts.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/lib/parse_opts.c b/lib/parse_opts.c
index 358106e..8a235b1 100644
--- a/lib/parse_opts.c
+++ b/lib/parse_opts.c
@@ -139,8 +139,10 @@ static int  STD_LP_shmem=0; 	/* flag to do shmem_puts and gets during TEST_LOOPI
 static int  STD_LD_recfun=0;	/* do recressive function calls in loop delay */
 static int  STD_LP_recfun=0;	/* do recressive function calls in TEST_LOOPING */
 static int  STD_TP_sbrk=0;	/* do sbrk in TEST_PAUSE */
+#ifndef UCLINUX
 static int  STD_LP_sbrk=0;	/* do sbrk in TEST_LOOPING */
 static char *STD_start_break=0; /* original sbrk size */
+#endif
 static int  Debug=0;
 
 struct std_option_t {
-- 
1.7.1


[-- Attachment #3: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 01/21] lib/parse_opts: STD_LP_sbrk and STD_start_break should only be defined when UCLINUX=0

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 117 bytes --]

please use `git send-email` to properly post patches.  attaching them like 
this makes it a pita to review.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 01/21] lib/parse_opts: STD_LP_sbrk and STD_start_break should only be defined when UCLINUX=0

[Garrett Cooper]

On Tue, Jan 3, 2012 at 12:28 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> please use `git send-email` to properly post patches.  attaching them like
> this makes it a pita to review.

+1. Or just use what's noted in the style guide as well for submitting
patches if you really want to go down this path of creating patch
review/commit request emails.
Thanks,
-Garrett

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 01/21] lib/parse_opts: STD_LP_sbrk and STD_start_break should only be defined when UCLINUX=0

[Markos Chandras]

On 01/03/2012 10:17 PM, Garrett Cooper wrote:
> On Tue, Jan 3, 2012 at 12:28 PM, Mike Frysinger<vapier@gentoo.org>  wrote:
>> please use `git send-email` to properly post patches.  attaching them like
>> this makes it a pita to review.
>
> +1. Or just use what's noted in the style guide as well for submitting
> patches if you really want to go down this path of creating patch
> review/commit request emails.
> Thanks,
> -Garrett
Thanks. I will do that from now on.

-- 
markos


------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list