Re: [LTP] [PATCH] mq_timedsend/5-1: make parent has chance to sleep

[Caspar Zhang <caspar@casparzhang.com>]

On 2011年12月31日 11:32, Kang Kai wrote:
> Child process sends the last signal before parent process enter the
> final sleep sometimes, so sleep in parent will not be interrupted then
> the case fails.
> Sleep 1 second before send the last signal in child to make sure parent
> enter the final sleep.
> 
> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> ---
>  .../conformance/interfaces/mq_timedsend/5-1.c      |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/mq_timedsend/5-1.c b/testcases/open_posix_testsuite/conformance/interfaces/mq_timedsend/5-1.c
> index 96daf72..37993c8 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/mq_timedsend/5-1.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/mq_timedsend/5-1.c
> @@ -82,6 +82,9 @@ int main()
>  		sleep(1);  // give parent time to set up handler
>  		for (i=0; i<MAXMSG+1; i++) {
>          		mq_timedsend(gqueue, msgptr, strlen(msgptr), 1, &ts);
> +            /* make sure parent enter the final sleep */
> +			if (i == MAXMSG) 
> +                sleep(1);

You only make sure parent enters to the last iteration before child
does, but same issue still might occur in previous iterations.

Also, please use hard tab instead of 4/8 spaces for indentation. patch
style-guide could be found at: doc/style-guide.txt

Thanks,
Caspar

>  			/* send signal to parent each time message is sent */
>  			kill(getppid(), SIGABRT);
>  		}
> @@ -138,4 +141,4 @@ int main()
>  	}
>  
>  	return PTS_UNRESOLVED;
> -}
> \ No newline at end of file
> +}


------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list