Re: [LTP] [PATCH 1/2] getcontext01: fix build using uClibc C runtime

[Carmelo AMOROSO <carmelo.amoroso@st.com>]

On 18/01/2012 16.16, Mike Frysinger wrote:
> On Wednesday 18 January 2012 09:36:47 Carmelo AMOROSO wrote:
>> --- a/testcases/kernel/syscalls/getcontext/getcontext01.c +++
>> b/testcases/kernel/syscalls/getcontext/getcontext01.c
>> 
>> #include <features.h> +#include <unistd.h> +#include "test.h" 
>> +char *TCID = "getcontext01";	/* Test program identifier.    */ 
>> + #if !defined(__UCLIBC__)
>> 
>> #include <stdio.h> -#include <unistd.h> #include <errno.h> 
>> #include <ucontext.h>
>> 
>> -#include "test.h" #include "usctest.h"
> 
> all of the system includes should come before LTP includes.  i
> would just move the whole block above the #ifdef check.
> 

ok, make sense.


> also, checking __UCLIBC__ is a bit broken now ... we should use
> configure.ac to test for the func and change this test
> accordingly.

yeah... there are few other occurrences of testing for __UCLIBC__ macro.
I should have sent this a lot of times ago ;-)

I'd send a new version moving the include block all together, and
keeping for now the __UCLIBC__ check, as a temporary solution.

> -mike

thanks,
carmelo


------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list