Re: [LTP] [PATCH v3 1/8] A library used to test memcg

[Peng Haitao <penght@cn.fujitsu.com>]

Jan Stancek said the following on 2012-1-20 20:06:
> last update of this series had different version on some patches,
> some were v2 and some v3. I'll be referring to it as 'v3'.
> 
> I ran all v3 test cases. They worked fine, just 2 comments:
> 

Thanks.

> 1. file mode of new test cases is 644, existing one (memcg_function_test) is 755.
> I'm not sure if installation process takes care of this, I put them to testcases/bin
> directly (I was lazy), so I had to "chmod a+x" new ones to run them.
> 

I will modify file mode of new test cases to 755.

> 2. memcg_use_hierarchy generates some errors, which are expected
> For example:
> ltp/testcases/bin/memcg_use_hierarchy_test.sh: line 53: echo: write error: Device or resource busy
> testcases/bin/memcg_use_hierarchy_test.sh: line 64: echo: write error: Invalid argument
> 
> Just by reading log, it isn't obvious, that these errors are expected.
> I'd suggest "2> /dev/null" or if you want to keep it in log, then add
> some note, that these are expected.
> 

I will add "2> /dev/null".

Thanks very much.

-- 
Best Regards,
Peng


------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list