Re: [LTP] [PATCH v3 1/4] hugemmap01: auto mount the temporary dir for testing

Re: [LTP] [PATCH v3 1/4] hugemmap01: auto mount the temporary dir for testing

[Caspar Zhang]

On 02/08/2012 04:21 PM, Wanlong Gao wrote:
> -static void setup(void)
> +void setup(void)
>  {
> -	char mypid[40];
> -
> -	sprintf(mypid, "/%d", getpid());
> -	TEMPFILE = strcat(mypid, TEMPFILE);
> -	TEMPFILE = strcat(Hopt, TEMPFILE);
> -
> -	tst_sig(FORK, DEF_HANDLER, cleanup);
> -
>  	TEST_PAUSE;
> -
> +	tst_require_root(NULL);
> +	if (mount("none", Hopt, "hugetlbfs", 0, NULL) < 0)
> +		tst_brkm(TBROK|TERRNO, NULL,
> +			 "mount failed on %s", Hopt);
> +
> +	set_sys_tune("nr_hugepages", hugepages, 1);
> +	snprintf(TEMPFILE, sizeof(TEMPFILE), "%s/mmapfile%d",
> +		 Hopt, getpid());
>  }
>  
> -static void cleanup(void)
> +void cleanup(void)
>  {
>  	TEST_CLEANUP;
>  
>  	unlink(TEMPFILE);
>  
> +	umount(Hopt);
> +	tst_rmdir();
>  }

Hi, I just have another concern, that you might want to keep the initial
value of nr_hugepages and restore it once the test is done.

Thanks,
Caspar

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v3 1/4] hugemmap01: auto mount the temporary dir for testing

[Wanlong Gao]

On 02/08/2012 04:31 PM, Caspar Zhang wrote:

> On 02/08/2012 04:21 PM, Wanlong Gao wrote:
>> -static void setup(void)
>> +void setup(void)
>>  {
>> -	char mypid[40];
>> -
>> -	sprintf(mypid, "/%d", getpid());
>> -	TEMPFILE = strcat(mypid, TEMPFILE);
>> -	TEMPFILE = strcat(Hopt, TEMPFILE);
>> -
>> -	tst_sig(FORK, DEF_HANDLER, cleanup);
>> -
>>  	TEST_PAUSE;
>> -
>> +	tst_require_root(NULL);
>> +	if (mount("none", Hopt, "hugetlbfs", 0, NULL) < 0)
>> +		tst_brkm(TBROK|TERRNO, NULL,
>> +			 "mount failed on %s", Hopt);
>> +
>> +	set_sys_tune("nr_hugepages", hugepages, 1);
>> +	snprintf(TEMPFILE, sizeof(TEMPFILE), "%s/mmapfile%d",
>> +		 Hopt, getpid());
>>  }
>>  
>> -static void cleanup(void)
>> +void cleanup(void)
>>  {
>>  	TEST_CLEANUP;
>>  
>>  	unlink(TEMPFILE);
>>  
>> +	umount(Hopt);
>> +	tst_rmdir();
>>  }
> 
> Hi, I just have another concern, that you might want to keep the initial
> value of nr_hugepages and restore it once the test is done.


as set_sys_tune defined in mem lib, this restore work should be done there,
too.

right?

Thanks
-Wanlong Gao

> 
> Thanks,
> Caspar
> 



------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v3 1/4] hugemmap01: auto mount the temporary dir for testing

[Caspar Zhang]

On 02/08/2012 04:37 PM, Wanlong Gao wrote:
>> > Hi, I just have another concern, that you might want to keep the initial
>> > value of nr_hugepages and restore it once the test is done.
> 
> as set_sys_tune defined in mem lib, this restore work should be done there,
> too.

no, set_sys_tune only set the value and verify the content if the third
parameter is setting to "1".

You should save the original value by using get_sys_tune in setup() and
restore it in cleanup() by using set_sys_tune again.

Thanks,
Caspar

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v3 1/4] hugemmap01: auto mount the temporary dir for testing

[Wanlong Gao]

On 02/08/2012 04:41 PM, Caspar Zhang wrote:

> On 02/08/2012 04:37 PM, Wanlong Gao wrote:
>>>> Hi, I just have another concern, that you might want to keep the initial
>>>> value of nr_hugepages and restore it once the test is done.
>>
>> as set_sys_tune defined in mem lib, this restore work should be done there,
>> too.
> 
> no, set_sys_tune only set the value and verify the content if the third
> parameter is setting to "1".
> 
> You should save the original value by using get_sys_tune in setup() and
> restore it in cleanup() by using set_sys_tune again.


Ah, OK. I will do.

Thanks
-Wanlong Gao

> 
> Thanks,
> Caspar
> 



------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list