public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Caspar Zhang <caspar@casparzhang.com>
To: Filippo ARCIDIACONO <filippo.arcidiacono@st.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] getrusage03: add opportunity to reduce memory allocation's size
Date: Wed, 15 Feb 2012 18:24:23 +0800	[thread overview]
Message-ID: <4F3B87D7.4090700@casparzhang.com> (raw)
In-Reply-To: <4f3b6c8d.c1cb0e0a.3e38.354dSMTPIN_ADDED@mx.google.com>

On 02/15/2012 04:27 PM, Filippo ARCIDIACONO wrote:
>>> > >  static void inherit_fork2(void)
>>> > >  {
>>> > >  	tst_resm(TINFO, "Testcase #02: fork inherit(cont.)");
>>> > >
>>> > >  	SAFE_GETRUSAGE(cleanup, RUSAGE_CHILDREN, &ru);
>>> > >  	tst_resm(TINFO, "initial.children = %ld", ru.ru_maxrss);
>>> > > -	if (is_in_delta(ru.ru_maxrss - 102400))
>>> > > -		tst_resm(TPASS, "initial.children ~= 100MB");
>>> > > +	if (is_in_delta(ru.ru_maxrss - (10240 * factor_nr)))
>>> > > +		tst_resm(TPASS, "initial.children ~= %dMB", size);
>> > 
>> > `size` in this function is not initialized?
> 'size' is globally defined, it is initialized in the main().
> 

Yes, but seems that you missed a "size = 10240 * factor_nr" here.

Thanks,
Caspar

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  parent reply	other threads:[~2012-02-15 10:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-14 15:33 [LTP] [PATCH] getrusage03: add opportunity to reduce memory allocation's size Filippo ARCIDIACONO
2012-02-15  4:09 ` Caspar Zhang
2012-02-15  8:27   ` Filippo ARCIDIACONO
     [not found]   ` <4f3b6c8d.c1cb0e0a.3e38.354dSMTPIN_ADDED@mx.google.com>
2012-02-15 10:24     ` Caspar Zhang [this message]
2012-02-15 10:46       ` Filippo ARCIDIACONO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3B87D7.4090700@casparzhang.com \
    --to=caspar@casparzhang.com \
    --cc=filippo.arcidiacono@st.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox