Re: [LTP] [PATCH 3/2] mm: fix possible node missing in write_cpusets

[Caspar Zhang <caspar@casparzhang.com>]

On 02/20/2012 09:49 PM, Zhouping Liu wrote:
> hi, caspar
>>
>>
>> If a system has noncontinuous nodes, or the node doesn't start from
>> 0,
>> write_cpusets() function may fail because it hard-coded second node
>> as
>> "node1". This patch fixes the function by fetching second node number
>> from the stored array.
>>
>> Tested-by: Caspar Zhang <caspar@casparzhang.com>
>> Signed-off-by: Caspar Zhang <caspar@casparzhang.com>
>> ---
>>  testcases/kernel/mem/include/mem.h |    4 ++--
>>  testcases/kernel/mem/ksm/ksm02.c   |    6 ++----
>>  testcases/kernel/mem/ksm/ksm04.c   |    6 ++----
>>  testcases/kernel/mem/lib/mem.c     |   21 +++++++++++++--------
>>  4 files changed, 19 insertions(+), 18 deletions(-)
>>
>>
> inside write_cpusets(),
>> 	fd = open(CPATH_NEW "/mems", O_WRONLY);
>> 	if (fd == -1) {
>> 		if (errno == ENOENT) {
>> 			fd = open(CPATH_NEW "/cpuset.mems", O_WRONLY);
>> 			if (fd == -1)
>> 				tst_brkm(TBROK|TERRNO, cleanup, "open %s", buf);
>> 		} else
>> 			tst_brkm(TBROK|TERRNO, cleanup, "open %s", buf);
>> 	}
>> 	if (write(fd, "1", 1) != 1)
> you maybe missed here, it should be:
> 
> snprintf(buf, BUFSIZ, "%ld", nd);
> if (wirte(fd, buf, strlen(buf)) !=strlen(buf))

you're right.

Thanks,
Caspar

> 
>> 		tst_brkm(TBROK|TERRNO, cleanup, "write %s", buf);
>> 	close(fd);
> 
> others is okay for me.
> 
> thanks,
> Zhouping


------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list