Re: [LTP] [PATCH] numa/numa_node_size: removed HAS_NUMA_H macro

[Caspar Zhang <caspar@casparzhang.com>]

On 03/02/2012 07:32 PM, Zhouping Liu wrote:
> HAS_NUMA_H should be HAVE_NUMA_H, and HAVE_NUMA_H is defined
> in config.h, so added the header file.
> 
> Signed-off-by: Zhouping Liu <zliu@redhat.com>
> ---
>  testcases/kernel/numa/numa_node_size.c |   11 +++++++----
>  1 files changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/testcases/kernel/numa/numa_node_size.c b/testcases/kernel/numa/numa_node_size.c
> index 3d71ff2..5992f56 100644
> --- a/testcases/kernel/numa/numa_node_size.c
> +++ b/testcases/kernel/numa/numa_node_size.c
> @@ -31,9 +31,12 @@
>  /*                                                                            */
>  /******************************************************************************/
>  
> +#include "config.h"
> +

no need to put a new line here ...

>  #include <stdio.h>
>  #include <stdlib.h>
> -#if HAS_NUMA_H
> +

here as well.

Anyway, I committed this patch with removing the 2 blank lines.

Thanks,
Caspar

> +#if HAVE_NUMA_H
>  #include <numa.h>
>  #endif
>  
> @@ -48,7 +51,7 @@ char *fmt_mem(unsigned long long mem, char *buf)
>  }
>  void hardware(void)
>  {
> -#if HAS_NUMA_H
> +#if HAVE_NUMA_H
>          int i;
>          int maxnode = numa_max_node();
>          printf("available: %d nodes (0-%d)\n", 1+maxnode, maxnode);
> @@ -64,7 +67,7 @@ void hardware(void)
>  }
>  int main()
>  {
> -#if HAS_NUMA_H
> +#if HAVE_NUMA_H
>          nodemask_t nodemask;
>          void hardware();
>          if (numa_available() < 0)
> @@ -83,4 +86,4 @@ int main()
>          printf("NUMA is not available\n");
>          return 1;
>  #endif
> -}
> \ No newline at end of file
> +}


------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list