* [LTP] [PATCH v2] getrusage04: add opportunity to increase the max [us]time increment
@ 2012-02-23 10:57 Filippo ARCIDIACONO
2012-03-02 14:39 ` Filippo ARCIDIACONO
[not found] ` <4f50dbc8.a868320a.04b0.03b4SMTPIN_ADDED@mx.google.com>
0 siblings, 2 replies; 9+ messages in thread
From: Filippo ARCIDIACONO @ 2012-02-23 10:57 UTC (permalink / raw)
To: ltp-list
On slow systems it could be needed to increase the max value [us]time
increment beetween two getrusage calls.
Signed-off-by: Filippo Arcidiacono <filippo.arcidiacono@st.com>
Signed-off-by: Salvatore Cro <salvatore.cro@st.com>
---
testcases/kernel/syscalls/getrusage/getrusage04.c | 44 +++++++++++++++++---
1 files changed, 37 insertions(+), 7 deletions(-)
diff --git a/testcases/kernel/syscalls/getrusage/getrusage04.c b/testcases/kernel/syscalls/getrusage/getrusage04.c
index 3bdd3b0..e142d22 100644
--- a/testcases/kernel/syscalls/getrusage/getrusage04.c
+++ b/testcases/kernel/syscalls/getrusage/getrusage04.c
@@ -54,11 +54,22 @@ int TST_TOTAL = 1;
#define BIAS_MAX 1000
#define RECORD_MAX 20
+#define FACTOR_MAX 10
#ifndef RUSAGE_THREAD
#define RUSAGE_THREAD 1
#endif
+static int opt_factor;
+static char *factor_str;
+static long factor_nr = 1;
+
+option_t child_options[] = {
+ { "m:", &opt_factor, &factor_str },
+ { NULL, NULL, NULL }
+};
+
+static void fusage(void);
static void busyloop(long wait);
static void setup(void);
static void cleanup(void);
@@ -69,8 +80,9 @@ int main(int argc, char *argv[])
unsigned long ulast, udelta, slast, sdelta;
int i, lc;
char *msg;
+ char msg_string[BUFSIZ];
- msg = parse_opts(argc, argv, NULL, NULL);
+ msg = parse_opts(argc, argv, child_options, fusage);
if (msg != NULL)
tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
@@ -80,6 +92,12 @@ int main(int argc, char *argv[])
setup();
+ if (opt_factor)
+ factor_nr = SAFE_STRTOL(cleanup, factor_str, 0, FACTOR_MAX);
+
+ tst_resm(TINFO, "Using %ld as multiply factor for max [us]time "
+ "increment (1000+%ldus)!", factor_nr, BIAS_MAX * factor_nr);
+
for (lc = 0; TEST_LOOPING(lc); lc++) {
Tst_count = 0; i = 0;
ulast = 0, slast = 0;
@@ -95,14 +113,20 @@ int main(int argc, char *argv[])
tst_resm(TINFO, "utime:%12luus; stime:%12luus",
usage.ru_utime.tv_usec,
usage.ru_stime.tv_usec);
- if (udelta > 1000+BIAS_MAX)
- tst_brkm(TFAIL, cleanup,
- "utime increased > 1000us:"
+ if (udelta > 1000+(BIAS_MAX * factor_nr)) {
+ sprintf(msg_string,
+ "utime increased > %ldus:",
+ 1000 + BIAS_MAX * factor_nr);
+ tst_brkm(TFAIL, cleanup, msg_string,
" delta = %luus", udelta);
- if (sdelta > 1000+BIAS_MAX)
- tst_brkm(TFAIL, cleanup,
- "stime increased > 1000us:"
+ }
+ if (sdelta > 1000+(BIAS_MAX * factor_nr)) {
+ sprintf(msg_string,
+ "stime increased > %ldus:",
+ 1000 + BIAS_MAX * factor_nr);
+ tst_brkm(TFAIL, cleanup, msg_string,
" delta = %luus", sdelta);
+ }
}
ulast = usage.ru_utime.tv_usec;
slast = usage.ru_stime.tv_usec;
@@ -113,6 +137,12 @@ int main(int argc, char *argv[])
tst_exit();
}
+static void fusage(void)
+{
+ printf(" -m n use n as multiply factor for max [us]time "
+ "increment (1000+(1000*n)us),\n default value is 1\n");
+}
+
static void busyloop(long wait)
{
while (wait--)
--
1.5.5.6
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase the max [us]time increment
2012-02-23 10:57 [LTP] [PATCH v2] getrusage04: add opportunity to increase the max [us]time increment Filippo ARCIDIACONO
@ 2012-03-02 14:39 ` Filippo ARCIDIACONO
[not found] ` <4f50dbc8.a868320a.04b0.03b4SMTPIN_ADDED@mx.google.com>
1 sibling, 0 replies; 9+ messages in thread
From: Filippo ARCIDIACONO @ 2012-03-02 14:39 UTC (permalink / raw)
To: 'Filippo ARCIDIACONO', ltp-list
> -----Original Message-----
> From: Filippo ARCIDIACONO [mailto:filippo.arcidiacono@st.com]
> Sent: Thursday, February 23, 2012 11:58 AM
> To: ltp-list@lists.sourceforge.net
> Cc: Filippo Arcidiacono; Salvatore Cro
> Subject: [PATCH v2] getrusage04: add opportunity to increase the max
> [us]time increment
>
> On slow systems it could be needed to increase the max value [us]time
> increment beetween two getrusage calls.
>
> Signed-off-by: Filippo Arcidiacono <filippo.arcidiacono@st.com>
> Signed-off-by: Salvatore Cro <salvatore.cro@st.com>
> ---
> testcases/kernel/syscalls/getrusage/getrusage04.c | 44
> +++++++++++++++++---
> 1 files changed, 37 insertions(+), 7 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/getrusage/getrusage04.c
> b/testcases/kernel/syscalls/getrusage/getrusage04.c
> index 3bdd3b0..e142d22 100644
> --- a/testcases/kernel/syscalls/getrusage/getrusage04.c
> +++ b/testcases/kernel/syscalls/getrusage/getrusage04.c
> @@ -54,11 +54,22 @@ int TST_TOTAL = 1;
>
> #define BIAS_MAX 1000
> #define RECORD_MAX 20
> +#define FACTOR_MAX 10
>
> #ifndef RUSAGE_THREAD
> #define RUSAGE_THREAD 1
> #endif
>
> +static int opt_factor;
> +static char *factor_str;
> +static long factor_nr = 1;
> +
> +option_t child_options[] = {
> + { "m:", &opt_factor, &factor_str },
> + { NULL, NULL, NULL }
> +};
> +
> +static void fusage(void);
> static void busyloop(long wait);
> static void setup(void);
> static void cleanup(void);
> @@ -69,8 +80,9 @@ int main(int argc, char *argv[])
> unsigned long ulast, udelta, slast, sdelta;
> int i, lc;
> char *msg;
> + char msg_string[BUFSIZ];
>
> - msg = parse_opts(argc, argv, NULL, NULL);
> + msg = parse_opts(argc, argv, child_options, fusage);
> if (msg != NULL)
> tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
>
> @@ -80,6 +92,12 @@ int main(int argc, char *argv[])
>
> setup();
>
> + if (opt_factor)
> + factor_nr = SAFE_STRTOL(cleanup, factor_str, 0,
> FACTOR_MAX);
> +
> + tst_resm(TINFO, "Using %ld as multiply factor for max [us]time "
> + "increment (1000+%ldus)!", factor_nr, BIAS_MAX *
> factor_nr);
> +
> for (lc = 0; TEST_LOOPING(lc); lc++) {
> Tst_count = 0; i = 0;
> ulast = 0, slast = 0;
> @@ -95,14 +113,20 @@ int main(int argc, char *argv[])
> tst_resm(TINFO, "utime:%12luus;
stime:%12luus",
> usage.ru_utime.tv_usec,
> usage.ru_stime.tv_usec);
> - if (udelta > 1000+BIAS_MAX)
> - tst_brkm(TFAIL, cleanup,
> - "utime increased >
1000us:"
> + if (udelta > 1000+(BIAS_MAX * factor_nr)) {
> + sprintf(msg_string,
> + "utime increased > %ldus:",
> + 1000 + BIAS_MAX *
factor_nr);
> + tst_brkm(TFAIL, cleanup, msg_string,
> " delta = %luus",
udelta);
> - if (sdelta > 1000+BIAS_MAX)
> - tst_brkm(TFAIL, cleanup,
> - "stime increased >
1000us:"
> + }
> + if (sdelta > 1000+(BIAS_MAX * factor_nr)) {
> + sprintf(msg_string,
> + "stime increased > %ldus:",
> + 1000 + BIAS_MAX *
factor_nr);
> + tst_brkm(TFAIL, cleanup, msg_string,
> " delta = %luus",
sdelta);
> + }
> }
> ulast = usage.ru_utime.tv_usec;
> slast = usage.ru_stime.tv_usec;
> @@ -113,6 +137,12 @@ int main(int argc, char *argv[])
> tst_exit();
> }
>
> +static void fusage(void)
> +{
> + printf(" -m n use n as multiply factor for max [us]time "
> + "increment (1000+(1000*n)us),\n default value is
> 1\n");
> +}
> +
> static void busyloop(long wait)
> {
> while (wait--)
> --
> 1.5.5.6
Is this version ok for you, or there are any other comments?
Thanks,
Filippo.
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase the max [us]time increment
[not found] ` <4f50dbc8.a868320a.04b0.03b4SMTPIN_ADDED@mx.google.com>
@ 2012-03-05 7:55 ` Caspar Zhang
2012-03-05 8:05 ` Wanlong Gao
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Caspar Zhang @ 2012-03-05 7:55 UTC (permalink / raw)
To: Filippo ARCIDIACONO; +Cc: ltp-list
On 03/02/2012 10:39 PM, Filippo ARCIDIACONO wrote:
>> -----Original Message-----
>> From: Filippo ARCIDIACONO [mailto:filippo.arcidiacono@st.com]
>> Sent: Thursday, February 23, 2012 11:58 AM
>> To: ltp-list@lists.sourceforge.net
>> Cc: Filippo Arcidiacono; Salvatore Cro
>> Subject: [PATCH v2] getrusage04: add opportunity to increase the max
>> [us]time increment
>>
>> On slow systems it could be needed to increase the max value [us]time
>> increment beetween two getrusage calls.
>>
>> Signed-off-by: Filippo Arcidiacono <filippo.arcidiacono@st.com>
>> Signed-off-by: Salvatore Cro <salvatore.cro@st.com>
>> ---
...
> Is this version ok for you, or there are any other comments?
I meet some `DOS line endings` errors when I am trying to merge this
patch. Could you double check your patch with checkpatch.pl from kernel
source tree? (or my mail client is broken :-(...
Thanks,
Caspar
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase the max [us]time increment
2012-03-05 7:55 ` Caspar Zhang
@ 2012-03-05 8:05 ` Wanlong Gao
2012-03-05 9:30 ` Filippo ARCIDIACONO
[not found] ` <4f5487be.50640e0a.6a60.4e49SMTPIN_ADDED@mx.google.com>
2 siblings, 0 replies; 9+ messages in thread
From: Wanlong Gao @ 2012-03-05 8:05 UTC (permalink / raw)
To: Caspar Zhang; +Cc: ltp-list
On 03/05/2012 03:55 PM, Caspar Zhang wrote:
> On 03/02/2012 10:39 PM, Filippo ARCIDIACONO wrote:
>>> -----Original Message-----
>>> From: Filippo ARCIDIACONO [mailto:filippo.arcidiacono@st.com]
>>> Sent: Thursday, February 23, 2012 11:58 AM
>>> To: ltp-list@lists.sourceforge.net
>>> Cc: Filippo Arcidiacono; Salvatore Cro
>>> Subject: [PATCH v2] getrusage04: add opportunity to increase the max
>>> [us]time increment
>>>
>>> On slow systems it could be needed to increase the max value [us]time
>>> increment beetween two getrusage calls.
>>>
>>> Signed-off-by: Filippo Arcidiacono <filippo.arcidiacono@st.com>
>>> Signed-off-by: Salvatore Cro <salvatore.cro@st.com>
>>> ---
>
> ...
>
>> Is this version ok for you, or there are any other comments?
>
> I meet some `DOS line endings` errors when I am trying to merge this
> patch. Could you double check your patch with checkpatch.pl from kernel
> source tree? (or my mail client is broken :-(...
Hi Caspar:
You can pull this patch from http://github.com/gaowanlong/ltp master
Thanks
-Wanlong Gao
>
> Thanks,
> Caspar
>
> ------------------------------------------------------------------------------
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase the max [us]time increment
2012-03-05 7:55 ` Caspar Zhang
2012-03-05 8:05 ` Wanlong Gao
@ 2012-03-05 9:30 ` Filippo ARCIDIACONO
2012-03-05 9:33 ` Wanlong Gao
[not found] ` <4f5487be.50640e0a.6a60.4e49SMTPIN_ADDED@mx.google.com>
2 siblings, 1 reply; 9+ messages in thread
From: Filippo ARCIDIACONO @ 2012-03-05 9:30 UTC (permalink / raw)
To: 'Caspar Zhang'; +Cc: ltp-list
> -----Original Message-----
> From: Caspar Zhang [mailto:caspar@casparzhang.com]
> Sent: Monday, March 05, 2012 8:55 AM
> To: Filippo ARCIDIACONO
> Cc: ltp-list@lists.sourceforge.net
> Subject: Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase
> the max [us]time increment
>
> On 03/02/2012 10:39 PM, Filippo ARCIDIACONO wrote:
> >> -----Original Message-----
> >> From: Filippo ARCIDIACONO [mailto:filippo.arcidiacono@st.com]
> >> Sent: Thursday, February 23, 2012 11:58 AM
> >> To: ltp-list@lists.sourceforge.net
> >> Cc: Filippo Arcidiacono; Salvatore Cro
> >> Subject: [PATCH v2] getrusage04: add opportunity to increase the max
> >> [us]time increment
> >>
> >> On slow systems it could be needed to increase the max value
> [us]time
> >> increment beetween two getrusage calls.
> >>
> >> Signed-off-by: Filippo Arcidiacono <filippo.arcidiacono@st.com>
> >> Signed-off-by: Salvatore Cro <salvatore.cro@st.com>
> >> ---
>
> ...
>
> > Is this version ok for you, or there are any other comments?
>
> I meet some `DOS line endings` errors when I am trying to merge this
> patch. Could you double check your patch with checkpatch.pl from kernel
> source tree? (or my mail client is broken :-(...
I checked the patch with checkpatch.pl and no issue are raised.
I sent the patch by means of "git send-email".
>
> Thanks,
> Caspar
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase the max [us]time increment
2012-03-05 9:30 ` Filippo ARCIDIACONO
@ 2012-03-05 9:33 ` Wanlong Gao
2012-03-05 10:51 ` Caspar Zhang
0 siblings, 1 reply; 9+ messages in thread
From: Wanlong Gao @ 2012-03-05 9:33 UTC (permalink / raw)
To: Filippo ARCIDIACONO; +Cc: ltp-list
On 03/05/2012 05:30 PM, Filippo ARCIDIACONO wrote:
>
>
>> -----Original Message-----
>> From: Caspar Zhang [mailto:caspar@casparzhang.com]
>> Sent: Monday, March 05, 2012 8:55 AM
>> To: Filippo ARCIDIACONO
>> Cc: ltp-list@lists.sourceforge.net
>> Subject: Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase
>> the max [us]time increment
>>
>> On 03/02/2012 10:39 PM, Filippo ARCIDIACONO wrote:
>>>> -----Original Message-----
>>>> From: Filippo ARCIDIACONO [mailto:filippo.arcidiacono@st.com]
>>>> Sent: Thursday, February 23, 2012 11:58 AM
>>>> To: ltp-list@lists.sourceforge.net
>>>> Cc: Filippo Arcidiacono; Salvatore Cro
>>>> Subject: [PATCH v2] getrusage04: add opportunity to increase the max
>>>> [us]time increment
>>>>
>>>> On slow systems it could be needed to increase the max value
>> [us]time
>>>> increment beetween two getrusage calls.
>>>>
>>>> Signed-off-by: Filippo Arcidiacono <filippo.arcidiacono@st.com>
>>>> Signed-off-by: Salvatore Cro <salvatore.cro@st.com>
>>>> ---
>>
>> ...
>>
>>> Is this version ok for you, or there are any other comments?
>>
>> I meet some `DOS line endings` errors when I am trying to merge this
>> patch. Could you double check your patch with checkpatch.pl from kernel
>> source tree? (or my mail client is broken :-(...
>
> I checked the patch with checkpatch.pl and no issue are raised.
> I sent the patch by means of "git send-email".
Yes, it's all right.
see here: https://github.com/gaowanlong/ltp/commit/9d12e835fdcd3624619be8b47e0f109343fc35e4
Thanks
-Wanlong Gao
>
>>
>> Thanks,
>> Caspar
>
>
> ------------------------------------------------------------------------------
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase the max [us]time increment
[not found] ` <4f5487be.50640e0a.6a60.4e49SMTPIN_ADDED@mx.google.com>
@ 2012-03-05 9:53 ` Caspar Zhang
0 siblings, 0 replies; 9+ messages in thread
From: Caspar Zhang @ 2012-03-05 9:53 UTC (permalink / raw)
To: Filippo ARCIDIACONO; +Cc: ltp-list
On 03/05/2012 05:30 PM, Filippo ARCIDIACONO wrote:
>
>
>> -----Original Message-----
>> From: Caspar Zhang [mailto:caspar@casparzhang.com]
>> Sent: Monday, March 05, 2012 8:55 AM
>> To: Filippo ARCIDIACONO
>> Cc: ltp-list@lists.sourceforge.net
>> Subject: Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase
>> the max [us]time increment
>>
>> On 03/02/2012 10:39 PM, Filippo ARCIDIACONO wrote:
>>>> -----Original Message-----
>>>> From: Filippo ARCIDIACONO [mailto:filippo.arcidiacono@st.com]
>>>> Sent: Thursday, February 23, 2012 11:58 AM
>>>> To: ltp-list@lists.sourceforge.net
>>>> Cc: Filippo Arcidiacono; Salvatore Cro
>>>> Subject: [PATCH v2] getrusage04: add opportunity to increase the max
>>>> [us]time increment
>>>>
>>>> On slow systems it could be needed to increase the max value
>> [us]time
>>>> increment beetween two getrusage calls.
>>>>
>>>> Signed-off-by: Filippo Arcidiacono <filippo.arcidiacono@st.com>
>>>> Signed-off-by: Salvatore Cro <salvatore.cro@st.com>
>>>> ---
>>
>> ...
>>
>>> Is this version ok for you, or there are any other comments?
>>
>> I meet some `DOS line endings` errors when I am trying to merge this
>> patch. Could you double check your patch with checkpatch.pl from kernel
>> source tree? (or my mail client is broken :-(...
>
> I checked the patch with checkpatch.pl and no issue are raised.
> I sent the patch by means of "git send-email".
Committed. Thanks.
Caspar
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase the max [us]time increment
2012-03-05 9:33 ` Wanlong Gao
@ 2012-03-05 10:51 ` Caspar Zhang
2012-03-05 11:05 ` Filippo ARCIDIACONO
0 siblings, 1 reply; 9+ messages in thread
From: Caspar Zhang @ 2012-03-05 10:51 UTC (permalink / raw)
To: gaowanlong; +Cc: ltp-list
On 03/05/2012 05:33 PM, Wanlong Gao wrote:
> On 03/05/2012 05:30 PM, Filippo ARCIDIACONO wrote:
>
>>
>>
>>> -----Original Message-----
>>> From: Caspar Zhang [mailto:caspar@casparzhang.com]
>>> Sent: Monday, March 05, 2012 8:55 AM
>>> To: Filippo ARCIDIACONO
>>> Cc: ltp-list@lists.sourceforge.net
>>> Subject: Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase
>>> the max [us]time increment
>>>
>>> On 03/02/2012 10:39 PM, Filippo ARCIDIACONO wrote:
>>>>> -----Original Message-----
>>>>> From: Filippo ARCIDIACONO [mailto:filippo.arcidiacono@st.com]
>>>>> Sent: Thursday, February 23, 2012 11:58 AM
>>>>> To: ltp-list@lists.sourceforge.net
>>>>> Cc: Filippo Arcidiacono; Salvatore Cro
>>>>> Subject: [PATCH v2] getrusage04: add opportunity to increase the max
>>>>> [us]time increment
>>>>>
>>>>> On slow systems it could be needed to increase the max value
>>> [us]time
>>>>> increment beetween two getrusage calls.
>>>>>
>>>>> Signed-off-by: Filippo Arcidiacono <filippo.arcidiacono@st.com>
>>>>> Signed-off-by: Salvatore Cro <salvatore.cro@st.com>
>>>>> ---
>>>
>>> ...
>>>
>>>> Is this version ok for you, or there are any other comments?
>>>
>>> I meet some `DOS line endings` errors when I am trying to merge this
>>> patch. Could you double check your patch with checkpatch.pl from kernel
>>> source tree? (or my mail client is broken :-(...
>>
>> I checked the patch with checkpatch.pl and no issue are raised.
>> I sent the patch by means of "git send-email".
>
>
> Yes, it's all right.
> see here: https://github.com/gaowanlong/ltp/commit/9d12e835fdcd3624619be8b47e0f109343fc35e4
>
Yup, my thunderbird should be blamed :-(
BTW, according to the style guide, it's recommended to send patches in
attachment format, you can generate such patches by adding --attach
option with `git format-patch` command.
Thanks,
Caspar
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase the max [us]time increment
2012-03-05 10:51 ` Caspar Zhang
@ 2012-03-05 11:05 ` Filippo ARCIDIACONO
0 siblings, 0 replies; 9+ messages in thread
From: Filippo ARCIDIACONO @ 2012-03-05 11:05 UTC (permalink / raw)
To: 'Caspar Zhang', gaowanlong; +Cc: ltp-list
> -----Original Message-----
> From: Caspar Zhang [mailto:caspar@casparzhang.com]
> Sent: Monday, March 05, 2012 11:52 AM
> To: gaowanlong@cn.fujitsu.com
> Cc: Filippo ARCIDIACONO; ltp-list@lists.sourceforge.net
> Subject: Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase
> the max [us]time increment
>
> On 03/05/2012 05:33 PM, Wanlong Gao wrote:
> > On 03/05/2012 05:30 PM, Filippo ARCIDIACONO wrote:
> >
> >>
> >>
> >>> -----Original Message-----
> >>> From: Caspar Zhang [mailto:caspar@casparzhang.com]
> >>> Sent: Monday, March 05, 2012 8:55 AM
> >>> To: Filippo ARCIDIACONO
> >>> Cc: ltp-list@lists.sourceforge.net
> >>> Subject: Re: [LTP] [PATCH v2] getrusage04: add opportunity to
> increase
> >>> the max [us]time increment
> >>>
> >>> On 03/02/2012 10:39 PM, Filippo ARCIDIACONO wrote:
> >>>>> -----Original Message-----
> >>>>> From: Filippo ARCIDIACONO [mailto:filippo.arcidiacono@st.com]
> >>>>> Sent: Thursday, February 23, 2012 11:58 AM
> >>>>> To: ltp-list@lists.sourceforge.net
> >>>>> Cc: Filippo Arcidiacono; Salvatore Cro
> >>>>> Subject: [PATCH v2] getrusage04: add opportunity to increase the
> max
> >>>>> [us]time increment
> >>>>>
> >>>>> On slow systems it could be needed to increase the max value
> >>> [us]time
> >>>>> increment beetween two getrusage calls.
> >>>>>
> >>>>> Signed-off-by: Filippo Arcidiacono <filippo.arcidiacono@st.com>
> >>>>> Signed-off-by: Salvatore Cro <salvatore.cro@st.com>
> >>>>> ---
> >>>
> >>> ...
> >>>
> >>>> Is this version ok for you, or there are any other comments?
> >>>
> >>> I meet some `DOS line endings` errors when I am trying to merge
> this
> >>> patch. Could you double check your patch with checkpatch.pl from
> kernel
> >>> source tree? (or my mail client is broken :-(...
> >>
> >> I checked the patch with checkpatch.pl and no issue are raised.
> >> I sent the patch by means of "git send-email".
> >
> >
> > Yes, it's all right.
> > see here:
> https://github.com/gaowanlong/ltp/commit/9d12e835fdcd3624619be8b47e0f10
> 9343fc35e4
> >
>
> Yup, my thunderbird should be blamed :-(
>
> BTW, according to the style guide, it's recommended to send patches in
> attachment format, you can generate such patches by adding --attach
> option with `git format-patch` command.
Thanks for the suggestion.
I'll take into account next time.
>
> Thanks,
> Caspar
Thanks,
Filippo
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-03-05 11:06 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-23 10:57 [LTP] [PATCH v2] getrusage04: add opportunity to increase the max [us]time increment Filippo ARCIDIACONO
2012-03-02 14:39 ` Filippo ARCIDIACONO
[not found] ` <4f50dbc8.a868320a.04b0.03b4SMTPIN_ADDED@mx.google.com>
2012-03-05 7:55 ` Caspar Zhang
2012-03-05 8:05 ` Wanlong Gao
2012-03-05 9:30 ` Filippo ARCIDIACONO
2012-03-05 9:33 ` Wanlong Gao
2012-03-05 10:51 ` Caspar Zhang
2012-03-05 11:05 ` Filippo ARCIDIACONO
[not found] ` <4f5487be.50640e0a.6a60.4e49SMTPIN_ADDED@mx.google.com>
2012-03-05 9:53 ` Caspar Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox