public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp-list@lists.sourceforge.net, Jeffrey Burke <jburke@redhat.com>
Subject: Re: [LTP] [PATCH] readlink03: fix expected errno for kernel >=3.2
Date: Wed, 14 Mar 2012 22:04:05 +0800	[thread overview]
Message-ID: <4F60A555.1030100@cn.fujitsu.com> (raw)
In-Reply-To: <389bdf61-8e14-45b2-adbf-66c1d0ac3a96@zmail17.collab.prod.int.phx2.redhat.com>

On 03/14/2012 09:57 PM, Jan Stancek wrote:

> 
> 
> ----- Original Message -----
>> From: "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
>> To: "Jan Stancek" <jstancek@redhat.com>
>> Cc: ltp-list@lists.sourceforge.net, "Jeffrey Burke" <jburke@redhat.com>
>> Sent: Wednesday, March 14, 2012 1:50:56 PM
>> Subject: Re: [LTP] [PATCH] readlink03: fix expected errno for kernel >=3.2
>>
>> Hi Jan,
>>
>>>
>>> This kernel commit restored original behavior:
>>> commit 1fa1e7f615f4d3ae436fa319af6e4eebdd4026a8
>>> Author: Andy Whitcroft <apw@canonical.com>
>>> Date:   Wed Nov 2 09:44:39 2011 +0100
>>>     readlinkat: ensure we return ENOENT for the empty pathname for
>>> normal lookups
>>>
>>> For kernel >= 3.2, ENOENT should be expected errno code.
>>
>>
>> I had posted a patch long time ago, you can see here
>> http://marc.info/?l=ltp-list&m=132063831228321&w=2
>>
>> This is a kernel bug, and already fixed in 3.0 and 3.1
>> stable tree, so, just test the kernel version like this
>> is not the best method.
>>
>> What do you think?
> 
> Agreed, version check doesn't make much sense.
> 
> I think if this patch was important enough to be backported to stable
> trees, we can be sure it's a bug and we can drop that version
> check entirely - which is what your patch does.


Yeah, so let me resend it with your Ack.

Thanks,
Wanlong Gao

> 
> Regards,
> Jan
> 
> 



------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2012-03-14 14:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14 11:44 [LTP] [PATCH] readlink03: fix expected errno for kernel >=3.2 Jan Stancek
2012-03-14 12:50 ` Wanlong Gao
2012-03-14 13:57   ` Jan Stancek
2012-03-14 14:04     ` Wanlong Gao [this message]
2012-03-14 13:08 ` Caspar Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F60A555.1030100@cn.fujitsu.com \
    --to=gaowanlong@cn.fujitsu.com \
    --cc=jburke@redhat.com \
    --cc=jstancek@redhat.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox