[LTP] [PATCH] io_submit: uninitialized iocb may not return -EINVAL

Jan Stancek
2012-03-14T14:53:14Z

[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]

Testcase 1.3 - EINVAL: uninitialized iocb
is about submitting uninitialized iocb structure.

Test is expecting to get -EINVAL, but other values are also
possible as uninitialized struct can contain any values.

For example following data fails with -EBADF:
--- snip ---
unsigned char bad_iocb[64] = {
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x84, 0xa5,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x0f, 0xff, 0xe0, 0x10, 0x0c, 0x30,
0x00, 0x00, 0x0f, 0xff, 0xe0, 0x10, 0x0c, 0x40,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
memcpy(&iocb, bad_iocb, sizeof(iocb));
iocbs[0] = &iocb;
TEST(io_submit(ctx, 1, iocbs));
check_result(-EINVAL, TEST_RETURN);
--- snip ---

This patch accepts also few other errno codes as valid return value.

Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
testcases/kernel/syscalls/io_submit/io_submit01.c | 16 +++++++++++++++-
1 files changed, 15 insertions(+), 1 deletions(-)

[-- Attachment #2: 0001-io_submit-uninitialized-iocb-may-not-return-EINVAL.patch --]
[-- Type: text/x-patch, Size: 991 bytes --]

diff --git a/testcases/kernel/syscalls/io_submit/io_submit01.c b/testcases/kernel/syscalls/io_submit/io_submit01.c
index da15aa0..3983fa4 100644
--- a/testcases/kernel/syscalls/io_submit/io_submit01.c
+++ b/testcases/kernel/syscalls/io_submit/io_submit01.c
@@ -126,7 +126,21 @@ int main(int argc, char *argv[])
/* 1.3 - EINVAL: uninitialized iocb */
iocbs[0] = &iocb;
TEST(io_submit(ctx, 1, iocbs));
- check_result(-EINVAL, TEST_RETURN);
+ switch(TEST_RETURN) {
+ case -EINVAL:
+ case -EBADF:
+ case -EFAULT:
+ case -EPERM:
+ tst_resm(TPASS, "expected failure - "
+ "returned value = %ld : %s",
+ TEST_RETURN, strerror(-1 * TEST_RETURN));
+ break;
+ default:
+ tst_resm(TFAIL, "unexpected failure - "
+ "returned value = %ld : %s, "
+ "expected one of -EINVAL, -EBADF, -EFAULT, -EPERM",
+ TEST_RETURN, strerror(-1 * TEST_RETURN));
+ }

/* 2 - EFAULT: iocb points to invalid data */
TEST(io_submit(ctx, 1, (struct iocb **)-1));

[-- Attachment #3: Type: text/plain, Size: 317 bytes --]

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]