Re: [LTP] [PATCH] io_submit: uninitialized iocb may not return -EINVAL

Wanlong Gao
2012-03-15T07:57:34Z

Hi Jan，

>>> --- a/testcases/kernel/syscalls/io_submit/io_submit01.c
>>> +++ b/testcases/kernel/syscalls/io_submit/io_submit01.c
>>> @@ -126,7 +126,21 @@ int main(int argc, char *argv[])
>>> /* 1.3 - EINVAL: uninitialized iocb */
>>> iocbs[0] = &iocb;
>>> TEST(io_submit(ctx, 1, iocbs));
>>> - check_result(-EINVAL, TEST_RETURN);
>>> + switch(TEST_RETURN) {
>>> + case -EINVAL:
>>> + case -EBADF:
>>> + case -EFAULT:
>>> + case -EPERM:
>>
>>
>> I don't think io_submit(2) can return -EPERM.
>>
>> Do you think so?
>
> I was trying all sorts of random data and I remember seeing once "-1".
> I'm failing to reproduce it today, so I could be wrong. If I fail to find
> data that gives -EPERM, I'll remove it in v2.

I looked into the io_submit(2) code in kernel and didn't see any path can
return -EPERM, so I think you should confirm on it again.

Thanks,
Wanlong Gao

>
> Regards,
> Jan
>
>>
>> Thanks,
>> Wanlong Gao
>>
>
>

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here