From: Caspar Zhang <caspar@casparzhang.com>
To: gaowanlong@cn.fujitsu.com
Cc: andi.kleen@intel.com, ying.huang@intel.com,
LTP list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [RFC] make mce-test a submodule
Date: Fri, 16 Mar 2012 15:27:44 +0800 [thread overview]
Message-ID: <4F62EB70.7010400@casparzhang.com> (raw)
In-Reply-To: <4F594DE2.4040603@cn.fujitsu.com>
Hi all, I'll merge this change to master if I don't hear any objections
from you by today.
On 03/09/2012 08:25 AM, Wanlong Gao wrote:
> On 03/09/2012 12:50 AM, Caspar Zhang wrote:
>
>> Hi Garrett, Andi, and all:
>>
>> When I looked into current LTP tree, I found it a little messy due to
>> some mce-test stuff, such as
>>
>> - mce-test docs goes to $TOPDIR/README, and
>> - some mce-test files still lying under testcase/mce-test/.
>>
>> I think we need a cleanup for it.
>
>
> yes, I think so.
>
>>
>> Also an idea comes to my mind, that we can try to make mce-test a
>> submodule of LTP.
>
>
> Not a bad idea.
>
>>
>> I am also thinking about the pros and cons:
>>
>> pro(s):
>> - easier for code maintenance, no need to sync periodically from
>> maintainer side
>>
>> con(s):
>> - two extra steps added for LTP users, they have to do:
>> $ git submodule init
>> $ git submodule update
>> to enable using mce-test.
>>
>> mce-test could no longer be found at kernel.org, so I cloned it from
>> Andi's github repo, not sure if it is the right place:
>>
>> git://github.com/andikleen/mce-test.git
>
>
> The tree seems just a few update every month now, I wonder why intel guys
> didn't sync the commits to LTP ?
>
>>
>> I have made this change to my personal LTP fork, you can review it here:
>>
>> https://github.com/casparant/ltp/commit/5cca17f633
>
>
> The patch loooks good.
Wanlong, thanks for review.
Thanks,
Caspar
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-03-16 7:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4F58E36E.5000306@casparzhang.com>
2012-03-09 0:25 ` [LTP] [RFC] make mce-test a submodule Wanlong Gao
2012-03-16 7:27 ` Caspar Zhang [this message]
2012-03-16 9:53 ` Garrett Cooper
2012-03-16 9:58 ` Wanlong Gao
2012-03-16 11:17 ` Caspar Zhang
2012-03-16 14:35 ` Andi Kleen
2012-03-21 9:18 ` Chen Gong
2012-04-06 14:33 ` Caspar Zhang
2012-04-09 3:10 ` Chen Gong
2012-04-09 4:03 ` Caspar Zhang
2012-04-09 6:02 ` Chen Gong
2012-04-09 6:05 ` Wanlong Gao
2012-04-09 6:07 ` Caspar Zhang
2012-04-17 2:03 ` Chen Gong
2012-04-17 2:38 ` Caspar Zhang
2012-05-23 1:52 ` Chen Gong
2012-05-30 9:37 ` Chen Gong
2012-05-30 10:25 ` Caspar Zhang
2012-05-31 2:06 ` Chen Gong
2012-04-06 14:37 ` Caspar Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F62EB70.7010400@casparzhang.com \
--to=caspar@casparzhang.com \
--cc=andi.kleen@intel.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox