From: Caspar Zhang <caspar@casparzhang.com>
To: Zhouping Liu <zliu@redhat.com>
Cc: LTP List <ltp-list@lists.sourceforge.net>, Cai Qian <caiqian@redhat.com>
Subject: Re: [LTP] [PATCH v3] mem/oom: avoid unexpected error when no memcg swap accounting
Date: Mon, 19 Mar 2012 19:28:24 +0800 [thread overview]
Message-ID: <4F671858.8020305@casparzhang.com> (raw)
In-Reply-To: <2fb866f36188a32158e9cb402adb5d59d9df27d2.1332151930.git.zliu@redhat.com>
On 03/19/2012 06:28 PM, Zhouping Liu wrote:
> Since commit http://git.kernel.org/linus/a42c390cfa0c,
> which added an option to control memcg swap, when kernel
> neither set CGROUP_MEM_RES_CTLR_SWAP_ENABLED nor add
> 'swapaccount=1' kernel parameter, that indicates memcg swap
> accounting is disabled, it will have no such file:
> memory.memsw.*, then oom03 & oom04 cases will fail.
>
> The patch fixed it: removed memsw cases when memcg swap
> accounting is disabled, and added a TCONF:
> tst_resm(TCONF,"memcg swap accounting is disabled");
>
> Signed-off-by: Zhouping Liu <zliu@redhat.com>
> Reviewed-by: Caspar Zhang <czhang@redhat.com>
>
...
> - write_file(MEMCG_PATH_NEW "/memory.memsw.limit_in_bytes", mem);
> - testoom(0, 1, 1);
> + if (swap_acc_on) {
You should remove trailing whitespace.
Committed with this update.
Thanks,
Caspar
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2012-03-19 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 10:28 [LTP] [PATCH v3] mem/oom: avoid unexpected error when no memcg swap accounting Zhouping Liu
2012-03-19 11:00 ` Wanlong Gao
2012-03-19 11:28 ` Caspar Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F671858.8020305@casparzhang.com \
--to=caspar@casparzhang.com \
--cc=caiqian@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=zliu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox