* Re: [LTP] [PATCH v4] aio_read:8-1.c: Forget initializing struct aiocb before using it [not found] ` <4F62F3F8.5080707@cn.fujitsu.com> @ 2012-03-16 9:48 ` Garrett Cooper 2012-03-16 10:07 ` Peng Haitao 0 siblings, 1 reply; 5+ messages in thread From: Garrett Cooper @ 2012-03-16 9:48 UTC (permalink / raw) To: gaowanlong@cn.fujitsu.com; +Cc: ltp-list@lists.sourceforge.net On Mar 16, 2012, at 1:04 AM, Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote: > On 03/16/2012 03:58 PM, Peng Haitao wrote: > >> There are 2 changes in this patch. >> 1. Initialize the aiocb struct before using it. >> 2. If Prioritized Input and Output option is supported, submit the >> aiocb with invalid aio_reqprio, else submit the aiocb with invalid >> aio_fildes >> >> Signed-off-by: Peng Haitao <penght@cn.fujitsu.com> > > > Looks good to me , Cyril? Why not always set fildes == -1 and test that way? >> .../conformance/interfaces/aio_read/8-1.c | 14 ++++++++------ >> .../conformance/interfaces/aio_write/6-1.c | 16 +++++++++------- >> 2 files changed, 17 insertions(+), 13 deletions(-) >> >> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c >> index 8054eeb..009aeb2 100644 >> --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c >> +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c >> @@ -14,7 +14,9 @@ >> * >> * method: >> * >> - * - fill in an aiocb with a NULL aio_buf >> + * - if Prioritized Input and Output option is supported, fill in an >> + * aiocb with invalid aio_reqprio, else submit the aiocb with invalid >> + * aio_fildes >> * - call aio_read >> * - check aio_read return value >> */ >> @@ -41,11 +43,11 @@ int main() >> if (sysconf(_SC_ASYNCHRONOUS_IO) < 200112L) >> return PTS_UNSUPPORTED; >> >> - /* submit a request with a NULL buffer */ >> - aiocb.aio_fildes = 0; >> - aiocb.aio_buf = NULL; >> - aiocb.aio_nbytes = 0; >> - aiocb.aio_offset = 0; >> + memset(&aiocb, 0, sizeof(struct aiocb)); >> + if (sysconf(_SC_PRIORITIZED_IO) < 200112L) >> + aiocb.aio_fildes = -1; >> + else >> + aiocb.aio_reqprio = -1; >> >> if (aio_read(&aiocb) != -1) { >> printf(TNAME " aio_read() should fail!\n"); >> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c >> index 98b8d0d..9234fe6 100644 >> --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c >> +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c >> @@ -14,7 +14,9 @@ >> * >> * method: >> * >> - * - fill in an aiocb with a NULL aio_buf >> + * - if Prioritized Input and Output option is supported, fill in an >> + * aiocb with invalid aio_reqprio, else submit the aiocb with invalid >> + * aio_fildes >> * - call aio_write >> * - check aio_write return value >> * >> @@ -42,11 +44,11 @@ int main() >> if (sysconf(_SC_ASYNCHRONOUS_IO) < 200112L) >> return PTS_UNSUPPORTED; >> >> - /* submit a request with a NULL buffer */ >> - aiocb.aio_fildes = 0; >> - aiocb.aio_buf = NULL; >> - aiocb.aio_nbytes = 0; >> - aiocb.aio_offset = 0; >> + memset(&aiocb, 0, sizeof(struct aiocb)); >> + if (sysconf(_SC_PRIORITIZED_IO) < 200112L) >> + aiocb.aio_fildes = -1; >> + else >> + aiocb.aio_reqprio = -1; >> >> if (aio_write(&aiocb) != -1) >> { >> @@ -62,4 +64,4 @@ int main() >> >> printf ("Test PASSED\n"); >> return PTS_PASS; >> -} >> \ No newline at end of file >> +} > > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH v4] aio_read:8-1.c: Forget initializing struct aiocb before using it 2012-03-16 9:48 ` [LTP] [PATCH v4] aio_read:8-1.c: Forget initializing struct aiocb before using it Garrett Cooper @ 2012-03-16 10:07 ` Peng Haitao 2012-03-21 8:43 ` [LTP] [PATCH v5] " Peng Haitao 0 siblings, 1 reply; 5+ messages in thread From: Peng Haitao @ 2012-03-16 10:07 UTC (permalink / raw) To: Garrett Cooper; +Cc: ltp-list@lists.sourceforge.net Garrett Cooper said the following on 2012-3-16 17:48: > On Mar 16, 2012, at 1:04 AM, Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote: > >> On 03/16/2012 03:58 PM, Peng Haitao wrote: >> >>> There are 2 changes in this patch. >>> 1. Initialize the aiocb struct before using it. >>> 2. If Prioritized Input and Output option is supported, submit the >>> aiocb with invalid aio_reqprio, else submit the aiocb with invalid >>> aio_fildes >>> >>> Signed-off-by: Peng Haitao <penght@cn.fujitsu.com> >> >> >> Looks good to me , Cyril? > > Why not always set fildes == -1 and test that way? > When Prioritized Input and Output option is supported，and aio_fildes is set -1, the aio_read() will success:( Only aiocb.aio_reqprio is set -1, the aio_read() will fail. When Prioritized Input and Output option is not supported，and aio_fildes is set -1, the result of aio_read() is not tested. But I think it is wrong when aio_fildes is set -1. -- Best Regards, Peng >>> .../conformance/interfaces/aio_read/8-1.c | 14 ++++++++------ >>> .../conformance/interfaces/aio_write/6-1.c | 16 +++++++++------- >>> 2 files changed, 17 insertions(+), 13 deletions(-) >>> >>> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c >>> index 8054eeb..009aeb2 100644 >>> --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c >>> +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c >>> @@ -14,7 +14,9 @@ >>> * >>> * method: >>> * >>> - * - fill in an aiocb with a NULL aio_buf >>> + * - if Prioritized Input and Output option is supported, fill in an >>> + * aiocb with invalid aio_reqprio, else submit the aiocb with invalid >>> + * aio_fildes >>> * - call aio_read >>> * - check aio_read return value >>> */ >>> @@ -41,11 +43,11 @@ int main() >>> if (sysconf(_SC_ASYNCHRONOUS_IO) < 200112L) >>> return PTS_UNSUPPORTED; >>> >>> - /* submit a request with a NULL buffer */ >>> - aiocb.aio_fildes = 0; >>> - aiocb.aio_buf = NULL; >>> - aiocb.aio_nbytes = 0; >>> - aiocb.aio_offset = 0; >>> + memset(&aiocb, 0, sizeof(struct aiocb)); >>> + if (sysconf(_SC_PRIORITIZED_IO) < 200112L) >>> + aiocb.aio_fildes = -1; >>> + else >>> + aiocb.aio_reqprio = -1; >>> >>> if (aio_read(&aiocb) != -1) { >>> printf(TNAME " aio_read() should fail!\n"); >>> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c >>> index 98b8d0d..9234fe6 100644 >>> --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c >>> +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c >>> @@ -14,7 +14,9 @@ >>> * >>> * method: >>> * >>> - * - fill in an aiocb with a NULL aio_buf >>> + * - if Prioritized Input and Output option is supported, fill in an >>> + * aiocb with invalid aio_reqprio, else submit the aiocb with invalid >>> + * aio_fildes >>> * - call aio_write >>> * - check aio_write return value >>> * >>> @@ -42,11 +44,11 @@ int main() >>> if (sysconf(_SC_ASYNCHRONOUS_IO) < 200112L) >>> return PTS_UNSUPPORTED; >>> >>> - /* submit a request with a NULL buffer */ >>> - aiocb.aio_fildes = 0; >>> - aiocb.aio_buf = NULL; >>> - aiocb.aio_nbytes = 0; >>> - aiocb.aio_offset = 0; >>> + memset(&aiocb, 0, sizeof(struct aiocb)); >>> + if (sysconf(_SC_PRIORITIZED_IO) < 200112L) >>> + aiocb.aio_fildes = -1; >>> + else >>> + aiocb.aio_reqprio = -1; >>> >>> if (aio_write(&aiocb) != -1) >>> { >>> @@ -62,4 +64,4 @@ int main() >>> >>> printf ("Test PASSED\n"); >>> return PTS_PASS; >>> -} >>> \ No newline at end of file >>> +} >> >> >> >> ------------------------------------------------------------------------------ >> This SF email is sponsosred by: >> Try Windows Azure free for 90 days Click Here >> http://p.sf.net/sfu/sfd2d-msazure >> _______________________________________________ >> Ltp-list mailing list >> Ltp-list@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/ltp-list > > ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH v5] aio_read:8-1.c: Forget initializing struct aiocb before using it 2012-03-16 10:07 ` Peng Haitao @ 2012-03-21 8:43 ` Peng Haitao 2012-03-21 8:45 ` Wanlong Gao 2012-03-22 13:07 ` Wanlong Gao 0 siblings, 2 replies; 5+ messages in thread From: Peng Haitao @ 2012-03-21 8:43 UTC (permalink / raw) To: gaowanlong, yanegomi; +Cc: ltp-list There are 2 changes in this patch. 1. Initialize the aiocb struct before using it. 2. If Prioritized Input and Output option is supported, submit the aiocb with invalid aio_reqprio, else return untested. Signed-off-by: Peng Haitao <penght@cn.fujitsu.com> --- .../conformance/interfaces/aio_read/8-1.c | 13 +++++++------ .../conformance/interfaces/aio_write/6-1.c | 15 ++++++++------- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c index 8054eeb..ea0538e 100644 --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c @@ -14,7 +14,8 @@ * * method: * - * - fill in an aiocb with a NULL aio_buf + * - if Prioritized Input and Output option is supported, fill in an + * aiocb with invalid aio_reqprio. * - call aio_read * - check aio_read return value */ @@ -41,11 +42,11 @@ int main() if (sysconf(_SC_ASYNCHRONOUS_IO) < 200112L) return PTS_UNSUPPORTED; - /* submit a request with a NULL buffer */ - aiocb.aio_fildes = 0; - aiocb.aio_buf = NULL; - aiocb.aio_nbytes = 0; - aiocb.aio_offset = 0; + if (sysconf(_SC_PRIORITIZED_IO) < 200112L) + return PTS_UNTESTED; + + memset(&aiocb, 0, sizeof(struct aiocb)); + aiocb.aio_reqprio = -1; if (aio_read(&aiocb) != -1) { printf(TNAME " aio_read() should fail!\n"); diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c index 98b8d0d..744c82c 100644 --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c @@ -14,7 +14,8 @@ * * method: * - * - fill in an aiocb with a NULL aio_buf + * - if Prioritized Input and Output option is supported, fill in an + * aiocb with invalid aio_reqprio * - call aio_write * - check aio_write return value * @@ -42,11 +43,11 @@ int main() if (sysconf(_SC_ASYNCHRONOUS_IO) < 200112L) return PTS_UNSUPPORTED; - /* submit a request with a NULL buffer */ - aiocb.aio_fildes = 0; - aiocb.aio_buf = NULL; - aiocb.aio_nbytes = 0; - aiocb.aio_offset = 0; + if (sysconf(_SC_PRIORITIZED_IO) < 200112L) + return PTS_UNTESTED; + + memset(&aiocb, 0, sizeof(struct aiocb)); + aiocb.aio_reqprio = -1; if (aio_write(&aiocb) != -1) { @@ -62,4 +63,4 @@ int main() printf ("Test PASSED\n"); return PTS_PASS; -} \ No newline at end of file +} -- 1.7.10.rc1 ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH v5] aio_read:8-1.c: Forget initializing struct aiocb before using it 2012-03-21 8:43 ` [LTP] [PATCH v5] " Peng Haitao @ 2012-03-21 8:45 ` Wanlong Gao 2012-03-22 13:07 ` Wanlong Gao 1 sibling, 0 replies; 5+ messages in thread From: Wanlong Gao @ 2012-03-21 8:45 UTC (permalink / raw) To: Peng Haitao; +Cc: ltp-list On 03/21/2012 04:43 PM, Peng Haitao wrote: > There are 2 changes in this patch. > 1. Initialize the aiocb struct before using it. > 2. If Prioritized Input and Output option is supported, submit the > aiocb with invalid aio_reqprio, else return untested. > > Signed-off-by: Peng Haitao <penght@cn.fujitsu.com> thanks Peng. ACK. > --- > .../conformance/interfaces/aio_read/8-1.c | 13 +++++++------ > .../conformance/interfaces/aio_write/6-1.c | 15 ++++++++------- > 2 files changed, 15 insertions(+), 13 deletions(-) > > diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c > index 8054eeb..ea0538e 100644 > --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c > +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c > @@ -14,7 +14,8 @@ > * > * method: > * > - * - fill in an aiocb with a NULL aio_buf > + * - if Prioritized Input and Output option is supported, fill in an > + * aiocb with invalid aio_reqprio. > * - call aio_read > * - check aio_read return value > */ > @@ -41,11 +42,11 @@ int main() > if (sysconf(_SC_ASYNCHRONOUS_IO) < 200112L) > return PTS_UNSUPPORTED; > > - /* submit a request with a NULL buffer */ > - aiocb.aio_fildes = 0; > - aiocb.aio_buf = NULL; > - aiocb.aio_nbytes = 0; > - aiocb.aio_offset = 0; > + if (sysconf(_SC_PRIORITIZED_IO) < 200112L) > + return PTS_UNTESTED; > + > + memset(&aiocb, 0, sizeof(struct aiocb)); > + aiocb.aio_reqprio = -1; > > if (aio_read(&aiocb) != -1) { > printf(TNAME " aio_read() should fail!\n"); > diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c > index 98b8d0d..744c82c 100644 > --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c > +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c > @@ -14,7 +14,8 @@ > * > * method: > * > - * - fill in an aiocb with a NULL aio_buf > + * - if Prioritized Input and Output option is supported, fill in an > + * aiocb with invalid aio_reqprio > * - call aio_write > * - check aio_write return value > * > @@ -42,11 +43,11 @@ int main() > if (sysconf(_SC_ASYNCHRONOUS_IO) < 200112L) > return PTS_UNSUPPORTED; > > - /* submit a request with a NULL buffer */ > - aiocb.aio_fildes = 0; > - aiocb.aio_buf = NULL; > - aiocb.aio_nbytes = 0; > - aiocb.aio_offset = 0; > + if (sysconf(_SC_PRIORITIZED_IO) < 200112L) > + return PTS_UNTESTED; > + > + memset(&aiocb, 0, sizeof(struct aiocb)); > + aiocb.aio_reqprio = -1; > > if (aio_write(&aiocb) != -1) > { > @@ -62,4 +63,4 @@ int main() > > printf ("Test PASSED\n"); > return PTS_PASS; > -} > \ No newline at end of file > +} ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH v5] aio_read:8-1.c: Forget initializing struct aiocb before using it 2012-03-21 8:43 ` [LTP] [PATCH v5] " Peng Haitao 2012-03-21 8:45 ` Wanlong Gao @ 2012-03-22 13:07 ` Wanlong Gao 1 sibling, 0 replies; 5+ messages in thread From: Wanlong Gao @ 2012-03-22 13:07 UTC (permalink / raw) To: Peng Haitao; +Cc: ltp-list On 03/21/2012 04:43 PM, Peng Haitao wrote: > There are 2 changes in this patch. > 1. Initialize the aiocb struct before using it. > 2. If Prioritized Input and Output option is supported, submit the > aiocb with invalid aio_reqprio, else return untested. pushed, thanks, Wanlong Gao > > Signed-off-by: Peng Haitao <penght@cn.fujitsu.com> > --- > .../conformance/interfaces/aio_read/8-1.c | 13 +++++++------ > .../conformance/interfaces/aio_write/6-1.c | 15 ++++++++------- > 2 files changed, 15 insertions(+), 13 deletions(-) > > diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c > index 8054eeb..ea0538e 100644 > --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c > +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_read/8-1.c > @@ -14,7 +14,8 @@ > * > * method: > * > - * - fill in an aiocb with a NULL aio_buf > + * - if Prioritized Input and Output option is supported, fill in an > + * aiocb with invalid aio_reqprio. > * - call aio_read > * - check aio_read return value > */ > @@ -41,11 +42,11 @@ int main() > if (sysconf(_SC_ASYNCHRONOUS_IO) < 200112L) > return PTS_UNSUPPORTED; > > - /* submit a request with a NULL buffer */ > - aiocb.aio_fildes = 0; > - aiocb.aio_buf = NULL; > - aiocb.aio_nbytes = 0; > - aiocb.aio_offset = 0; > + if (sysconf(_SC_PRIORITIZED_IO) < 200112L) > + return PTS_UNTESTED; > + > + memset(&aiocb, 0, sizeof(struct aiocb)); > + aiocb.aio_reqprio = -1; > > if (aio_read(&aiocb) != -1) { > printf(TNAME " aio_read() should fail!\n"); > diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c > index 98b8d0d..744c82c 100644 > --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c > +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_write/6-1.c > @@ -14,7 +14,8 @@ > * > * method: > * > - * - fill in an aiocb with a NULL aio_buf > + * - if Prioritized Input and Output option is supported, fill in an > + * aiocb with invalid aio_reqprio > * - call aio_write > * - check aio_write return value > * > @@ -42,11 +43,11 @@ int main() > if (sysconf(_SC_ASYNCHRONOUS_IO) < 200112L) > return PTS_UNSUPPORTED; > > - /* submit a request with a NULL buffer */ > - aiocb.aio_fildes = 0; > - aiocb.aio_buf = NULL; > - aiocb.aio_nbytes = 0; > - aiocb.aio_offset = 0; > + if (sysconf(_SC_PRIORITIZED_IO) < 200112L) > + return PTS_UNTESTED; > + > + memset(&aiocb, 0, sizeof(struct aiocb)); > + aiocb.aio_reqprio = -1; > > if (aio_write(&aiocb) != -1) > { > @@ -62,4 +63,4 @@ int main() > > printf ("Test PASSED\n"); > return PTS_PASS; > -} > \ No newline at end of file > +} ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-22 13:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4F62A9E1.2040502@cn.fujitsu.com>
[not found] ` <1331884731-11231-1-git-send-email-penght@cn.fujitsu.com>
[not found] ` <4F62F3F8.5080707@cn.fujitsu.com>
2012-03-16 9:48 ` [LTP] [PATCH v4] aio_read:8-1.c: Forget initializing struct aiocb before using it Garrett Cooper
2012-03-16 10:07 ` Peng Haitao
2012-03-21 8:43 ` [LTP] [PATCH v5] " Peng Haitao
2012-03-21 8:45 ` Wanlong Gao
2012-03-22 13:07 ` Wanlong Gao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox