* [LTP] [PATCH] mremap: fix dependency on ipc subdir
@ 2012-03-26 14:21 Jan Stancek
2012-03-27 2:35 ` Caspar Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Jan Stancek @ 2012-03-26 14:21 UTC (permalink / raw)
To: ltp-list; +Cc: Jeffrey Burke
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
We need to use MAKE_DEPS to declare the ipc subdir depend otherwise
attempting to do `make mremap01` without building in the ipc subdir
will fail, and we can hit race conditions in the overall `make`.
This is same change as in commit:
commit 7103d3e8e0f9dc1804ba06ee66ee02753e8ce50e
Author: Mike Frysinger <vapier@gentoo.org>
Date: Fri Mar 23 12:27:13 2012 -0400
kill: fix dependency on ipc subdir
Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
testcases/kernel/syscalls/mremap/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
[-- Attachment #2: 0001-mremap-fix-dependency-on-ipc-subdir.patch --]
[-- Type: text/x-patch, Size: 422 bytes --]
diff --git a/testcases/kernel/syscalls/mremap/Makefile b/testcases/kernel/syscalls/mremap/Makefile
index 63e7485..102e473 100644
--- a/testcases/kernel/syscalls/mremap/Makefile
+++ b/testcases/kernel/syscalls/mremap/Makefile
@@ -32,7 +32,7 @@ $(LIBDIR):
$(LIB): $(LIBDIR)
$(MAKE) -C $^ -f "$(abs_srcdir)/$^/Makefile" all
-all: | $(LIB)
+MAKE_DEPS := $(LIB)
CPPFLAGS += -I$(abs_srcdir)/$(LIBDIR)
[-- Attachment #3: Type: text/plain, Size: 191 bytes --]
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] mremap: fix dependency on ipc subdir
2012-03-26 14:21 [LTP] [PATCH] mremap: fix dependency on ipc subdir Jan Stancek
@ 2012-03-27 2:35 ` Caspar Zhang
2012-03-27 3:10 ` Wanlong Gao
0 siblings, 1 reply; 3+ messages in thread
From: Caspar Zhang @ 2012-03-27 2:35 UTC (permalink / raw)
To: Jan Stancek; +Cc: ltp-list, Jeffrey Burke
On 03/26/2012 10:21 PM, Jan Stancek wrote:
>
> We need to use MAKE_DEPS to declare the ipc subdir depend otherwise
> attempting to do `make mremap01` without building in the ipc subdir
> will fail, and we can hit race conditions in the overall `make`.
>
> This is same change as in commit:
> commit 7103d3e8e0f9dc1804ba06ee66ee02753e8ce50e
> Author: Mike Frysinger <vapier@gentoo.org>
> Date: Fri Mar 23 12:27:13 2012 -0400
> kill: fix dependency on ipc subdir
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
Reviewed-by: Caspar Zhang <caspar@casparzhang.com>
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] mremap: fix dependency on ipc subdir
2012-03-27 2:35 ` Caspar Zhang
@ 2012-03-27 3:10 ` Wanlong Gao
0 siblings, 0 replies; 3+ messages in thread
From: Wanlong Gao @ 2012-03-27 3:10 UTC (permalink / raw)
To: Caspar Zhang; +Cc: ltp-list, Jeffrey Burke
On 03/27/2012 10:35 AM, Caspar Zhang wrote:
> On 03/26/2012 10:21 PM, Jan Stancek wrote:
>>
>> We need to use MAKE_DEPS to declare the ipc subdir depend otherwise
>> attempting to do `make mremap01` without building in the ipc subdir
>> will fail, and we can hit race conditions in the overall `make`.
>>
>> This is same change as in commit:
>> commit 7103d3e8e0f9dc1804ba06ee66ee02753e8ce50e
>> Author: Mike Frysinger <vapier@gentoo.org>
>> Date: Fri Mar 23 12:27:13 2012 -0400
>> kill: fix dependency on ipc subdir
>>
>> Signed-off-by: Jan Stancek <jstancek@redhat.com>
>
> Reviewed-by: Caspar Zhang <caspar@casparzhang.com>
Thanks Jan, Caspar pushed,
Wanlong Gao
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-27 3:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-26 14:21 [LTP] [PATCH] mremap: fix dependency on ipc subdir Jan Stancek
2012-03-27 2:35 ` Caspar Zhang
2012-03-27 3:10 ` Wanlong Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox