Re: [LTP] [PATCH 0/4] Replace commonly used perl tools with awk equivalents

[Caspar Zhang <caspar@casparzhang.com>]

On 04/06/2012 11:34 AM, Garrett Cooper wrote:
> On Wed, Apr 4, 2012 at 6:49 PM, Mike Frysinger <vapier@gentoo.org> wrote:
>> On Wednesday 04 April 2012 20:33:40 Garrett Cooper wrote:
>>> On Wed, 4 Apr 2012, Mike Frysinger wrote:
>>>> On Wednesday 04 April 2012 15:18:53 Garrett Cooper wrote:
>>>>> On Wed, Apr 4, 2012 at 10:54 AM, Mike Frysinger wrote:
>>>>>> On Wednesday 04 April 2012 13:31:10 Garrett Cooper wrote:
>>>>>>> On Wed, Apr 4, 2012 at 10:22 AM, Mike Frysinger wrote:
>>>>>>>> On Wednesday 04 April 2012 01:23:43 Garrett Cooper wrote:
>>>>>>>>> The intent behind these changes are to remove unnecessary perl
>>>>>>>>> dependencies in LTP by using awk in its stead. It was something that
>>>>>>>>> was discussed a while ago on ltp-list@.
>>>>>>>>
>>>>>>>> i like awk over perl a lot.  my only concern is non-POSIX stuff
>>>>>>>> slipping in (such as people who have gawk installed).  should we add
>>>>>>>> a local wrapper script that sees if the awk accepts a --posix flag
>>>>>>>> and automatically pass it ?
>>>>>>>
>>>>>>> That's actually a gawk-ism :)...
>>>>>>
>>>>>> yes, that's why i phrased it "if the awk accepts"
>>>>>>
>>>>>> awk --help | grep -q -e --posix && args="${args} --posix"
>>>>>
>>>>> This makes sense and it would protect against gawk'isms, but not other
>>>>> *awk-isms.
>>>>
>>>> sure, but some protection is better than none.  if other awks have
>>>> similar knobs, we can leverage them too.
>>>
>>> Agreed, but this should be handled in other commits, right?
>>
>> sure, i'm not saying let's hold up the conversion from perl.  but we should do
>> it at some point imo.
> 
>     Are there any objections to the proposed [final?] patches I
> submitted for this patch set?
> Thanks!

looks good to me.

Reviewed-by: Caspar Zhang <caspar@casparzhang.com>

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list