public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH] logrotate01: fix a bug of config file's permission is wrong
@ 2012-05-11  2:37 Peng Haitao
  2012-05-11  4:13 ` Caspar Zhang
  0 siblings, 1 reply; 3+ messages in thread
From: Peng Haitao @ 2012-05-11  2:37 UTC (permalink / raw)
  To: ltp-list

config file's permission should be 644, please refer to:
https://fedorahosted.org/logrotate/changeset/302

Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
---
 testcases/commands/logrotate/logrotate_tests.sh |    1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/commands/logrotate/logrotate_tests.sh b/testcases/commands/logrotate/logrotate_tests.sh
index 827dd5f..55ef0b3 100755
--- a/testcases/commands/logrotate/logrotate_tests.sh
+++ b/testcases/commands/logrotate/logrotate_tests.sh
@@ -192,6 +192,7 @@ test01()
 		rm -f $files > /dev/null 2>&1
 	done
 
+	chmod 644 $LTPTMP/tst_logrotate.conf
 	logrotate -fv $LTPTMP/tst_logrotate.conf > $LTPTMP/tst_logrotate.out 2>&1 \
 		|| RC=$?
 	if [ $RC -eq 0 ]
-- 
1.7.10


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [LTP] [PATCH] logrotate01: fix a bug of config file's permission is wrong
  2012-05-11  2:37 [LTP] [PATCH] logrotate01: fix a bug of config file's permission is wrong Peng Haitao
@ 2012-05-11  4:13 ` Caspar Zhang
  2012-05-11  5:30   ` Wanlong Gao
  0 siblings, 1 reply; 3+ messages in thread
From: Caspar Zhang @ 2012-05-11  4:13 UTC (permalink / raw)
  To: Peng Haitao; +Cc: ltp-list

On 05/11/2012 10:37 AM, Peng Haitao wrote:
> config file's permission should be 644, please refer to:
> https://fedorahosted.org/logrotate/changeset/302
> 
> Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>

Reviewed-by: Caspar Zhang <caspar@casparzhang.com>

> ---
>  testcases/commands/logrotate/logrotate_tests.sh |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/testcases/commands/logrotate/logrotate_tests.sh b/testcases/commands/logrotate/logrotate_tests.sh
> index 827dd5f..55ef0b3 100755
> --- a/testcases/commands/logrotate/logrotate_tests.sh
> +++ b/testcases/commands/logrotate/logrotate_tests.sh
> @@ -192,6 +192,7 @@ test01()
>  		rm -f $files > /dev/null 2>&1
>  	done
>  
> +	chmod 644 $LTPTMP/tst_logrotate.conf
>  	logrotate -fv $LTPTMP/tst_logrotate.conf > $LTPTMP/tst_logrotate.out 2>&1 \
>  		|| RC=$?
>  	if [ $RC -eq 0 ]


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [LTP] [PATCH] logrotate01: fix a bug of config file's permission is wrong
  2012-05-11  4:13 ` Caspar Zhang
@ 2012-05-11  5:30   ` Wanlong Gao
  0 siblings, 0 replies; 3+ messages in thread
From: Wanlong Gao @ 2012-05-11  5:30 UTC (permalink / raw)
  To: Caspar Zhang; +Cc: ltp-list

On 05/11/2012 12:13 PM, Caspar Zhang wrote:

> On 05/11/2012 10:37 AM, Peng Haitao wrote:
>> config file's permission should be 644, please refer to:
>> https://fedorahosted.org/logrotate/changeset/302
>>
>> Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
> 
> Reviewed-by: Caspar Zhang <caspar@casparzhang.com>


pushed, thanks,

Wanlong Gao

> 
>> ---
>>  testcases/commands/logrotate/logrotate_tests.sh |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/testcases/commands/logrotate/logrotate_tests.sh b/testcases/commands/logrotate/logrotate_tests.sh
>> index 827dd5f..55ef0b3 100755
>> --- a/testcases/commands/logrotate/logrotate_tests.sh
>> +++ b/testcases/commands/logrotate/logrotate_tests.sh
>> @@ -192,6 +192,7 @@ test01()
>>  		rm -f $files > /dev/null 2>&1
>>  	done
>>  
>> +	chmod 644 $LTPTMP/tst_logrotate.conf
>>  	logrotate -fv $LTPTMP/tst_logrotate.conf > $LTPTMP/tst_logrotate.out 2>&1 \
>>  		|| RC=$?
>>  	if [ $RC -eq 0 ]
> 
> 
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. Discussions 
> will include endpoint security, mobile security and the latest in malware 
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 



------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-05-11  5:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-11  2:37 [LTP] [PATCH] logrotate01: fix a bug of config file's permission is wrong Peng Haitao
2012-05-11  4:13 ` Caspar Zhang
2012-05-11  5:30   ` Wanlong Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox