From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Caspar Zhang <caspar@casparzhang.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] getcpu: remove the useless and improper kernel version check
Date: Mon, 21 May 2012 16:58:44 +0800 [thread overview]
Message-ID: <4FBA03C4.7020408@cn.fujitsu.com> (raw)
In-Reply-To: <4FBA01CE.5000407@casparzhang.com>
On 05/21/2012 04:50 PM, Caspar Zhang wrote:
> On 05/21/2012 04:38 PM, Wanlong Gao wrote:
>> Now, kernel version up to 3.x, check for 2.6.x is useless.
>
> The fix makes sense, however, "checking for 2.6.x" is still valid for
> old kernels (does LTP still support 2.4.x? I'm not sure...)
yes, you are right, as I said, the program itself already checked the
kernel version, check the kernel version at Makefile is conceptual wrong.
Thanks,
Wanlong Gao
>
> Anyway,
>
> Acked-by: Caspar Zhang <caspar@casparzhang.com>
>
>> Additionally, we already checked the kernel version in the
>> program itself.
>> Meanwhile, check the kernel version at compiling time is wrong,
>> we may not do testing on the same machine as compiling.
>>
>> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>> ---
>> testcases/kernel/syscalls/getcpu/Makefile | 14 --------------
>> 1 file changed, 14 deletions(-)
>>
>> diff --git a/testcases/kernel/syscalls/getcpu/Makefile b/testcases/kernel/syscalls/getcpu/Makefile
>> index b8bf68b..7a1a87a 100644
>> --- a/testcases/kernel/syscalls/getcpu/Makefile
>> +++ b/testcases/kernel/syscalls/getcpu/Makefile
>> @@ -19,18 +19,4 @@
>> top_srcdir ?= ../../../..
>>
>> include $(top_srcdir)/include/mk/testcases.mk
>> -
>> -ifneq ($(shell uname -r | grep -c "^2\.6\.*"), 1)
>> -
>> -MAKE_TARGETS :=
>> -
>> -.PHONY: no-all-install
>> -
>> -all install: no-all-install
>> -
>> -no-all-install:
>> - @echo "Warning: Kernel doesn't support this test case"
>> -
>> -endif
>> -
>> include $(top_srcdir)/include/mk/generic_leaf_target.mk
>
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-05-21 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1337589516-9731-1-git-send-email-gaowanlong@cn.fujitsu.com>
2012-05-21 8:50 ` [LTP] [PATCH] getcpu: remove the useless and improper kernel version check Caspar Zhang
2012-05-21 8:58 ` Wanlong Gao [this message]
2012-05-21 8:55 ` Garrett Cooper
2012-05-21 9:01 ` Wanlong Gao
2012-05-21 9:06 ` Garrett Cooper
2012-05-21 9:16 ` Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBA03C4.7020408@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=caspar@casparzhang.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox