Re: [LTP] [PATCH] getcpu: remove the useless and improper kernel version check

[Wanlong Gao <gaowanlong@cn.fujitsu.com>]

On 05/21/2012 04:55 PM, Garrett Cooper wrote:

> On May 21, 2012, at 1:38 AM, Wanlong Gao wrote:
> 
>> Now, kernel version up to 3.x, check for 2.6.x is useless.
> 
> I don't agree with this statement. LTP needs to be usable on 2.6.x for at least 2 years after 3.x's inception.
> 
>> Additionally, we already checked the kernel version in the
>> program itself.
>> Meanwhile, check the kernel version at compiling time is wrong,
>> we may not do testing on the same machine as compiling.
> 
> Agreed. I think that this check was incorrectly implemented. Furthermore, this causes confusion when the test case doesn't exist; it's better to stub out the test case in the source.
> 
> I would just remove the first line -- the rest of the info is valid.


You mean the commit log?

Thanks,
Wanlong Gao

> 
> Cheers!
> -Garrett



------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list