* Re: [LTP] [PATCH] getcpu: remove the useless and improper kernel version check [not found] <1337589516-9731-1-git-send-email-gaowanlong@cn.fujitsu.com> @ 2012-05-21 8:50 ` Caspar Zhang 2012-05-21 8:58 ` Wanlong Gao 2012-05-21 8:55 ` Garrett Cooper 1 sibling, 1 reply; 6+ messages in thread From: Caspar Zhang @ 2012-05-21 8:50 UTC (permalink / raw) To: Wanlong Gao; +Cc: ltp-list On 05/21/2012 04:38 PM, Wanlong Gao wrote: > Now, kernel version up to 3.x, check for 2.6.x is useless. The fix makes sense, however, "checking for 2.6.x" is still valid for old kernels (does LTP still support 2.4.x? I'm not sure...) Anyway, Acked-by: Caspar Zhang <caspar@casparzhang.com> > Additionally, we already checked the kernel version in the > program itself. > Meanwhile, check the kernel version at compiling time is wrong, > we may not do testing on the same machine as compiling. > > Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com> > --- > testcases/kernel/syscalls/getcpu/Makefile | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/testcases/kernel/syscalls/getcpu/Makefile b/testcases/kernel/syscalls/getcpu/Makefile > index b8bf68b..7a1a87a 100644 > --- a/testcases/kernel/syscalls/getcpu/Makefile > +++ b/testcases/kernel/syscalls/getcpu/Makefile > @@ -19,18 +19,4 @@ > top_srcdir ?= ../../../.. > > include $(top_srcdir)/include/mk/testcases.mk > - > -ifneq ($(shell uname -r | grep -c "^2\.6\.*"), 1) > - > -MAKE_TARGETS := > - > -.PHONY: no-all-install > - > -all install: no-all-install > - > -no-all-install: > - @echo "Warning: Kernel doesn't support this test case" > - > -endif > - > include $(top_srcdir)/include/mk/generic_leaf_target.mk ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] getcpu: remove the useless and improper kernel version check 2012-05-21 8:50 ` [LTP] [PATCH] getcpu: remove the useless and improper kernel version check Caspar Zhang @ 2012-05-21 8:58 ` Wanlong Gao 0 siblings, 0 replies; 6+ messages in thread From: Wanlong Gao @ 2012-05-21 8:58 UTC (permalink / raw) To: Caspar Zhang; +Cc: ltp-list On 05/21/2012 04:50 PM, Caspar Zhang wrote: > On 05/21/2012 04:38 PM, Wanlong Gao wrote: >> Now, kernel version up to 3.x, check for 2.6.x is useless. > > The fix makes sense, however, "checking for 2.6.x" is still valid for > old kernels (does LTP still support 2.4.x? I'm not sure...) yes, you are right, as I said, the program itself already checked the kernel version, check the kernel version at Makefile is conceptual wrong. Thanks, Wanlong Gao > > Anyway, > > Acked-by: Caspar Zhang <caspar@casparzhang.com> > >> Additionally, we already checked the kernel version in the >> program itself. >> Meanwhile, check the kernel version at compiling time is wrong, >> we may not do testing on the same machine as compiling. >> >> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com> >> --- >> testcases/kernel/syscalls/getcpu/Makefile | 14 -------------- >> 1 file changed, 14 deletions(-) >> >> diff --git a/testcases/kernel/syscalls/getcpu/Makefile b/testcases/kernel/syscalls/getcpu/Makefile >> index b8bf68b..7a1a87a 100644 >> --- a/testcases/kernel/syscalls/getcpu/Makefile >> +++ b/testcases/kernel/syscalls/getcpu/Makefile >> @@ -19,18 +19,4 @@ >> top_srcdir ?= ../../../.. >> >> include $(top_srcdir)/include/mk/testcases.mk >> - >> -ifneq ($(shell uname -r | grep -c "^2\.6\.*"), 1) >> - >> -MAKE_TARGETS := >> - >> -.PHONY: no-all-install >> - >> -all install: no-all-install >> - >> -no-all-install: >> - @echo "Warning: Kernel doesn't support this test case" >> - >> -endif >> - >> include $(top_srcdir)/include/mk/generic_leaf_target.mk > > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] getcpu: remove the useless and improper kernel version check [not found] <1337589516-9731-1-git-send-email-gaowanlong@cn.fujitsu.com> 2012-05-21 8:50 ` [LTP] [PATCH] getcpu: remove the useless and improper kernel version check Caspar Zhang @ 2012-05-21 8:55 ` Garrett Cooper 2012-05-21 9:01 ` Wanlong Gao 1 sibling, 1 reply; 6+ messages in thread From: Garrett Cooper @ 2012-05-21 8:55 UTC (permalink / raw) To: Wanlong Gao; +Cc: ltp-list On May 21, 2012, at 1:38 AM, Wanlong Gao wrote: > Now, kernel version up to 3.x, check for 2.6.x is useless. I don't agree with this statement. LTP needs to be usable on 2.6.x for at least 2 years after 3.x's inception. > Additionally, we already checked the kernel version in the > program itself. > Meanwhile, check the kernel version at compiling time is wrong, > we may not do testing on the same machine as compiling. Agreed. I think that this check was incorrectly implemented. Furthermore, this causes confusion when the test case doesn't exist; it's better to stub out the test case in the source. I would just remove the first line -- the rest of the info is valid. Cheers! -Garrett ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] getcpu: remove the useless and improper kernel version check 2012-05-21 8:55 ` Garrett Cooper @ 2012-05-21 9:01 ` Wanlong Gao 2012-05-21 9:06 ` Garrett Cooper 0 siblings, 1 reply; 6+ messages in thread From: Wanlong Gao @ 2012-05-21 9:01 UTC (permalink / raw) To: Garrett Cooper; +Cc: ltp-list On 05/21/2012 04:55 PM, Garrett Cooper wrote: > On May 21, 2012, at 1:38 AM, Wanlong Gao wrote: > >> Now, kernel version up to 3.x, check for 2.6.x is useless. > > I don't agree with this statement. LTP needs to be usable on 2.6.x for at least 2 years after 3.x's inception. > >> Additionally, we already checked the kernel version in the >> program itself. >> Meanwhile, check the kernel version at compiling time is wrong, >> we may not do testing on the same machine as compiling. > > Agreed. I think that this check was incorrectly implemented. Furthermore, this causes confusion when the test case doesn't exist; it's better to stub out the test case in the source. > > I would just remove the first line -- the rest of the info is valid. You mean the commit log? Thanks, Wanlong Gao > > Cheers! > -Garrett ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] getcpu: remove the useless and improper kernel version check 2012-05-21 9:01 ` Wanlong Gao @ 2012-05-21 9:06 ` Garrett Cooper 2012-05-21 9:16 ` Wanlong Gao 0 siblings, 1 reply; 6+ messages in thread From: Garrett Cooper @ 2012-05-21 9:06 UTC (permalink / raw) To: gaowanlong; +Cc: ltp-list On May 21, 2012, at 2:01 AM, Wanlong Gao wrote: > On 05/21/2012 04:55 PM, Garrett Cooper wrote: > >> On May 21, 2012, at 1:38 AM, Wanlong Gao wrote: >> >>> Now, kernel version up to 3.x, check for 2.6.x is useless. >> >> I don't agree with this statement. LTP needs to be usable on 2.6.x for at least 2 years after 3.x's inception. >> >>> Additionally, we already checked the kernel version in the >>> program itself. >>> Meanwhile, check the kernel version at compiling time is wrong, >>> we may not do testing on the same machine as compiling. >> >> Agreed. I think that this check was incorrectly implemented. Furthermore, this causes confusion when the test case doesn't exist; it's better to stub out the test case in the source. >> >> I would just remove the first line -- the rest of the info is valid. > > You mean the commit log? Yeah.. -Garrett ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] getcpu: remove the useless and improper kernel version check 2012-05-21 9:06 ` Garrett Cooper @ 2012-05-21 9:16 ` Wanlong Gao 0 siblings, 0 replies; 6+ messages in thread From: Wanlong Gao @ 2012-05-21 9:16 UTC (permalink / raw) To: Garrett Cooper; +Cc: ltp-list On 05/21/2012 05:06 PM, Garrett Cooper wrote: > On May 21, 2012, at 2:01 AM, Wanlong Gao wrote: > >> On 05/21/2012 04:55 PM, Garrett Cooper wrote: >> >>> On May 21, 2012, at 1:38 AM, Wanlong Gao wrote: >>> >>>> Now, kernel version up to 3.x, check for 2.6.x is useless. >>> >>> I don't agree with this statement. LTP needs to be usable on 2.6.x for at least 2 years after 3.x's inception. >>> >>>> Additionally, we already checked the kernel version in the >>>> program itself. >>>> Meanwhile, check the kernel version at compiling time is wrong, >>>> we may not do testing on the same machine as compiling. >>> >>> Agreed. I think that this check was incorrectly implemented. Furthermore, this causes confusion when the test case doesn't exist; it's better to stub out the test case in the source. >>> >>> I would just remove the first line -- the rest of the info is valid. >> >> You mean the commit log? > > Yeah.. OK, pushed with your Acks. Thanks all involved. Wanlong Gao > -Garrett > > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-05-21 9:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1337589516-9731-1-git-send-email-gaowanlong@cn.fujitsu.com>
2012-05-21 8:50 ` [LTP] [PATCH] getcpu: remove the useless and improper kernel version check Caspar Zhang
2012-05-21 8:58 ` Wanlong Gao
2012-05-21 8:55 ` Garrett Cooper
2012-05-21 9:01 ` Wanlong Gao
2012-05-21 9:06 ` Garrett Cooper
2012-05-21 9:16 ` Wanlong Gao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox