From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] getcpu: remove the useless and improper kernel version check
Date: Mon, 21 May 2012 17:16:57 +0800 [thread overview]
Message-ID: <4FBA0809.5060800@cn.fujitsu.com> (raw)
In-Reply-To: <78627B6C-762E-4643-8E2D-38D2BF6B3332@gmail.com>
On 05/21/2012 05:06 PM, Garrett Cooper wrote:
> On May 21, 2012, at 2:01 AM, Wanlong Gao wrote:
>
>> On 05/21/2012 04:55 PM, Garrett Cooper wrote:
>>
>>> On May 21, 2012, at 1:38 AM, Wanlong Gao wrote:
>>>
>>>> Now, kernel version up to 3.x, check for 2.6.x is useless.
>>>
>>> I don't agree with this statement. LTP needs to be usable on 2.6.x for at least 2 years after 3.x's inception.
>>>
>>>> Additionally, we already checked the kernel version in the
>>>> program itself.
>>>> Meanwhile, check the kernel version at compiling time is wrong,
>>>> we may not do testing on the same machine as compiling.
>>>
>>> Agreed. I think that this check was incorrectly implemented. Furthermore, this causes confusion when the test case doesn't exist; it's better to stub out the test case in the source.
>>>
>>> I would just remove the first line -- the rest of the info is valid.
>>
>> You mean the commit log?
>
> Yeah..
OK, pushed with your Acks. Thanks all involved.
Wanlong Gao
> -Garrett
>
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2012-05-21 9:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1337589516-9731-1-git-send-email-gaowanlong@cn.fujitsu.com>
2012-05-21 8:50 ` [LTP] [PATCH] getcpu: remove the useless and improper kernel version check Caspar Zhang
2012-05-21 8:58 ` Wanlong Gao
2012-05-21 8:55 ` Garrett Cooper
2012-05-21 9:01 ` Wanlong Gao
2012-05-21 9:06 ` Garrett Cooper
2012-05-21 9:16 ` Wanlong Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBA0809.5060800@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox