From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1SWOkx-0007sB-J1 for ltp-list@lists.sourceforge.net; Mon, 21 May 2012 09:18:23 +0000 Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by sog-mx-1.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1SWOkt-0000Dw-E2 for ltp-list@lists.sourceforge.net; Mon, 21 May 2012 09:18:23 +0000 Message-ID: <4FBA0809.5060800@cn.fujitsu.com> Date: Mon, 21 May 2012 17:16:57 +0800 From: Wanlong Gao MIME-Version: 1.0 References: <1337589516-9731-1-git-send-email-gaowanlong@cn.fujitsu.com> <4FBA047D.7070703@cn.fujitsu.com> <78627B6C-762E-4643-8E2D-38D2BF6B3332@gmail.com> In-Reply-To: <78627B6C-762E-4643-8E2D-38D2BF6B3332@gmail.com> Subject: Re: [LTP] [PATCH] getcpu: remove the useless and improper kernel version check Reply-To: gaowanlong@cn.fujitsu.com List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Garrett Cooper Cc: ltp-list@lists.sourceforge.net On 05/21/2012 05:06 PM, Garrett Cooper wrote: > On May 21, 2012, at 2:01 AM, Wanlong Gao wrote: > >> On 05/21/2012 04:55 PM, Garrett Cooper wrote: >> >>> On May 21, 2012, at 1:38 AM, Wanlong Gao wrote: >>> >>>> Now, kernel version up to 3.x, check for 2.6.x is useless. >>> >>> I don't agree with this statement. LTP needs to be usable on 2.6.x for at least 2 years after 3.x's inception. >>> >>>> Additionally, we already checked the kernel version in the >>>> program itself. >>>> Meanwhile, check the kernel version at compiling time is wrong, >>>> we may not do testing on the same machine as compiling. >>> >>> Agreed. I think that this check was incorrectly implemented. Furthermore, this causes confusion when the test case doesn't exist; it's better to stub out the test case in the source. >>> >>> I would just remove the first line -- the rest of the info is valid. >> >> You mean the commit log? > > Yeah.. OK, pushed with your Acks. Thanks all involved. Wanlong Gao > -Garrett > > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list