Re: [LTP] [PATCH] Fix the fork/11-1 conformance testcase

[Wanlong Gao <gaowanlong@cn.fujitsu.com>]

On 05/26/2012 10:15 PM, Garrett Cooper wrote:

> The testcase tests to see whether or not locks are successfully
> inherited across forking processes, as the requirements for fork state
> that they should not be. The problem is that the test tests the negative
> case for ftrylockfile (!= 0) instead of the positive case, which creates


The ftrylockfile() function returns zero for success (the lock was obtained),
and nonzero for failure. 
So I think the origin is right.

Thanks,
Wanlong Gao

> an erroneous test failure as OUTPUT goes to /dev/stdout and the test
> hangs.
> 
> Signed-off-by: Garrett Cooper <yanegomi@gmail.com>
> 
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/fork/11-1.c
> b/testcases/open_posix_testsuite/conformance/interfaces/fork/11-1.c
> index ffff125..632b0db 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/fork/11-1.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/fork/11-1.c
> @@ -85,7 +85,7 @@ void * threaded(void * arg)
>         int ret;
>         ret = ftrylockfile(stdout);
> 
> -       if (ret != 0)
> +       if (ret == 0)
>         {
>                 FAILED("The child process is owning the file lock.");
>         }
> @@ -168,4 +168,4 @@ int main(int argc, char * argv[])
>  #endif
> 
>         PASSED;
> -}
> \ No newline at end of file
> +}
> 
> 
> 
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. Discussions 
> will include endpoint security, mobile security and the latest in malware 
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> 
> 
> 
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list



------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list