public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] ltp: Add patch to correct failing build from archive
@ 2012-06-06  7:29 Iorga, Cristian
  2012-06-14 23:37 ` Wanlong Gao
  0 siblings, 1 reply; 2+ messages in thread
From: Iorga, Cristian @ 2012-06-06  7:29 UTC (permalink / raw)
  To: ltp-list@lists.sourceforge.net


[-- Attachment #1.1: Type: text/plain, Size: 114 bytes --]

ltp: Add patch to correct failing build from archive

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>

[-- Attachment #1.2: Type: text/html, Size: 1808 bytes --]

[-- Attachment #2: fix_building_fom_archive.patch --]
[-- Type: application/octet-stream, Size: 752 bytes --]

ltp: Add patch to correct failing build
    
    ltp makefile does not interpret correctly the result of git describe
    command and assumes that it is working with a git repo, while in fact
    working with a source code archive.
    Added a patch to corect makefile system.
    Tested using dash as shell.

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>

Index: ltp-20120401/Makefile
===================================================================
--- ltp-20120401.orig/Makefile
+++ ltp-20120401/Makefile
@@ -173,7 +173,7 @@ SRCDIR_INSTALL_TARGETS	:= $(SRCDIR_INSTA
 #
 .PHONY: Version
 Version:
-	if git describe &> /dev/null; then \
+	if git describe > /dev/null 2>&1; then \
 		git describe > "$@"; \
 	else \
 		cp VERSION "$@"; \

[-- Attachment #3: Type: text/plain, Size: 395 bytes --]

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [LTP] ltp: Add patch to correct failing build from archive
  2012-06-06  7:29 [LTP] ltp: Add patch to correct failing build from archive Iorga, Cristian
@ 2012-06-14 23:37 ` Wanlong Gao
  0 siblings, 0 replies; 2+ messages in thread
From: Wanlong Gao @ 2012-06-14 23:37 UTC (permalink / raw)
  To: Iorga, Cristian; +Cc: ltp-list@lists.sourceforge.net

On 06/06/2012 03:29 PM, Iorga, Cristian wrote:
> ltp: Add patch to correct failing build from archive
> 
>  
> 
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>

Thanks Cristian, this already fixed in upstream.
refer to, 
https://github.com/linux-test-project/ltp/commit/dbd8b819c293d001b6ee6cb879871833ab23af8b

Wanlong Gao

> 
> 
> fix_building_fom_archive.patch
> 
> 
> ltp: Add patch to correct failing build
>     
>     ltp makefile does not interpret correctly the result of git describe
>     command and assumes that it is working with a git repo, while in fact
>     working with a source code archive.
>     Added a patch to corect makefile system.
>     Tested using dash as shell.
> 
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> 
> Index: ltp-20120401/Makefile
> ===================================================================
> --- ltp-20120401.orig/Makefile
> +++ ltp-20120401/Makefile
> @@ -173,7 +173,7 @@ SRCDIR_INSTALL_TARGETS	:= $(SRCDIR_INSTA
>  #
>  .PHONY: Version
>  Version:
> -	if git describe &> /dev/null; then \
> +	if git describe > /dev/null 2>&1; then \
>  		git describe > "$@"; \
>  	else \
>  		cp VERSION "$@"; \



------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-15  0:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-06  7:29 [LTP] ltp: Add patch to correct failing build from archive Iorga, Cristian
2012-06-14 23:37 ` Wanlong Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox