public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH/RFC] style-guide: sending patch series
@ 2012-06-29  8:44 Jan Stancek
  2012-06-29  8:53 ` Caspar Zhang
  0 siblings, 1 reply; 5+ messages in thread
From: Jan Stancek @ 2012-06-29  8:44 UTC (permalink / raw)
  To: ltp-list

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]


Add paragraph about sending patch series,
what is the preferred format and sample git config.

Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
 doc/style-guide.txt |   25 +++++++++++++++++++++++++
 1 files changed, 25 insertions(+), 0 deletions(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-style-guide-sending-patch-series.patch --]
[-- Type: text/x-patch; name="0001-style-guide-sending-patch-series.patch", Size: 1098 bytes --]

diff --git a/doc/style-guide.txt b/doc/style-guide.txt
index 414e70e..b3bfd8c 100644
--- a/doc/style-guide.txt
+++ b/doc/style-guide.txt
@@ -440,3 +440,28 @@ blah blah blah blah blah.
 
 Signed-off-by: John Smith <dev@null>
 -------------------------------------------------------------------
+
+Sending patch series
+
+Preferred format is shallow thread:
+[PATCH 0/X] XXXXXX
+  |_ [PATCH 1/X] YYYYYYYY
+  |_ [PATCH 2/X] ZZZZZZZZ
+
+Configure your git:
+cd <local copy of ltp repo>
+git config sendemail.thread false
+git config format.thread shallow
+git config format.numbered auto
+git config sendemail.signoffbycc false
+git config sendemail.suppresscc all
+git config sendemail.suppressfrom true
+git config sendemail.smtpserver "your.smtp.server"
+git config sendemail.confirm always
+
+Example, sending series consisting of 2 patches with git send-email:
+1. git format-patch --attach -2 --cover-letter
+2. edit subject and body of cover letter: 0000-cover-letter.patch
+3. git send-email --to ltp-list@lists.sourceforge.net \
+   0000-cover-letter.patch 0001-part1.patch 0002-part2.patch
+

[-- Attachment #3: Type: text/plain, Size: 395 bytes --]

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH/RFC] style-guide: sending patch series
  2012-06-29  8:44 [LTP] [PATCH/RFC] style-guide: sending patch series Jan Stancek
@ 2012-06-29  8:53 ` Caspar Zhang
  2012-06-29  9:03   ` [LTP] getrusage04 FAIL : stime increased > 2000us Nitin Yadav
  2012-07-09  7:00   ` [LTP] [PATCH/RFC] style-guide: sending patch series Jan Stancek
  0 siblings, 2 replies; 5+ messages in thread
From: Caspar Zhang @ 2012-06-29  8:53 UTC (permalink / raw)
  To: Jan Stancek; +Cc: ltp-list

On 06/29/2012 04:44 PM, Jan Stancek wrote:
> +git config format.numbered auto
> +git config sendemail.signoffbycc false
> +git config sendemail.suppresscc all
> +git config sendemail.suppressfrom true
> +git config sendemail.smtpserver "your.smtp.server"
> +git config sendemail.confirm always

These lines look like not related to thread-shallow issue?

Caspar

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [LTP] getrusage04  FAIL  :  stime increased > 2000us
  2012-06-29  8:53 ` Caspar Zhang
@ 2012-06-29  9:03   ` Nitin Yadav
  2012-07-09  7:00   ` [LTP] [PATCH/RFC] style-guide: sending patch series Jan Stancek
  1 sibling, 0 replies; 5+ messages in thread
From: Nitin Yadav @ 2012-06-29  9:03 UTC (permalink / raw)
  To: ltp-list

Hi,
I am getting below error after applying the patch (getrusage04: add
opportunity to increase the max [us]time increment) while running the
getrusage system call in Linux 3.2 kernel.

./getrusage04
getrusage04    0  TINFO  :  Using 1 as multiply factor for max [us]time
increment (1000+1000us)!
getrusage04    0  TINFO  :  utime:           0us; stime:           0us
getrusage04    0  TINFO  :  utime:           0us; stime:        4000us
getrusage04    1  TFAIL  :  stime increased > 2000us:


Please provide some pointers and suggestions.
Thanks!
Nitin Yadav

Information transmitted by this e-mail is proprietary to MphasiS, its associated companies and/ or its customers and is intended 
for use only by the individual or entity to which it is addressed, and may contain information that is privileged, confidential or 
exempt from disclosure under applicable law. If you are not the intended recipient or it appears that this mail has been forwarded 
to you without proper authority, you are notified that any use or dissemination of this information in any manner is strictly 
prohibited. In such cases, please notify us immediately at mailmaster@mphasis.com and delete this mail from your records.


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH/RFC] style-guide: sending patch series
  2012-06-29  8:53 ` Caspar Zhang
  2012-06-29  9:03   ` [LTP] getrusage04 FAIL : stime increased > 2000us Nitin Yadav
@ 2012-07-09  7:00   ` Jan Stancek
  2012-07-09 10:17     ` Caspar Zhang
  1 sibling, 1 reply; 5+ messages in thread
From: Jan Stancek @ 2012-07-09  7:00 UTC (permalink / raw)
  To: Caspar Zhang; +Cc: ltp-list



----- Original Message -----
> From: "Caspar Zhang" <caspar@casparzhang.com>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp-list@lists.sourceforge.net
> Sent: Friday, 29 June, 2012 10:53:55 AM
> Subject: Re: [LTP] [PATCH/RFC] style-guide: sending patch series
> 
> On 06/29/2012 04:44 PM, Jan Stancek wrote:
> > +git config format.numbered auto
> > +git config sendemail.signoffbycc false
> > +git config sendemail.suppresscc all
> > +git config sendemail.suppressfrom true
> > +git config sendemail.smtpserver "your.smtp.server"
> > +git config sendemail.confirm always
> 
> These lines look like not related to thread-shallow issue?

(sorry for late answer, was on holiday)

True, those are related to sending patch series with git send-email in general.
I took 'best practices' from different mailing list as initial suggestion.

Regards,
Jan

> 
> Caspar
> 

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH/RFC] style-guide: sending patch series
  2012-07-09  7:00   ` [LTP] [PATCH/RFC] style-guide: sending patch series Jan Stancek
@ 2012-07-09 10:17     ` Caspar Zhang
  0 siblings, 0 replies; 5+ messages in thread
From: Caspar Zhang @ 2012-07-09 10:17 UTC (permalink / raw)
  To: Jan Stancek; +Cc: ltp-list

On 07/09/2012 03:00 PM, Jan Stancek wrote:
> 
> 
> ----- Original Message -----
>> From: "Caspar Zhang" <caspar@casparzhang.com>
>> To: "Jan Stancek" <jstancek@redhat.com>
>> Cc: ltp-list@lists.sourceforge.net
>> Sent: Friday, 29 June, 2012 10:53:55 AM
>> Subject: Re: [LTP] [PATCH/RFC] style-guide: sending patch series
>>
>> On 06/29/2012 04:44 PM, Jan Stancek wrote:
>>> +git config format.numbered auto
>>> +git config sendemail.signoffbycc false
>>> +git config sendemail.suppresscc all
>>> +git config sendemail.suppressfrom true
>>> +git config sendemail.smtpserver "your.smtp.server"
>>> +git config sendemail.confirm always
>>
>> These lines look like not related to thread-shallow issue?
> 
> (sorry for late answer, was on holiday)
> 
> True, those are related to sending patch series with git send-email in general.
> I took 'best practices' from different mailing list as initial suggestion.

Okay. This caused a little confusion to me, I thought you were
suggesting use all configurations above as "shallow thread" style.

BTW, I don't think they[1] are necessary to put in style-guide.txt,
they're more likely to be tips instead.  i.e. we don't _require_ patch
contributor to avoid cc-ing to people in sign-off-by lines, nor require
they to suppress cc/from, blah, blah, etc.

Also, on my system, this line is not required either:

    +git config sendemail.thread false

once you have set this:

    +git config format.thread shallow

Whenever I enable or disable thread in sendemail section, the patchset
will be displayed as shallow format.

Thanks,
Caspar

[1] "they" refers to:
>>> +git config sendemail.signoffbycc false
>>> +git config sendemail.suppresscc all
>>> +git config sendemail.suppressfrom true
>>> +git config sendemail.smtpserver "your.smtp.server"
>>> +git config sendemail.confirm always

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-07-09 10:17 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-29  8:44 [LTP] [PATCH/RFC] style-guide: sending patch series Jan Stancek
2012-06-29  8:53 ` Caspar Zhang
2012-06-29  9:03   ` [LTP] getrusage04 FAIL : stime increased > 2000us Nitin Yadav
2012-07-09  7:00   ` [LTP] [PATCH/RFC] style-guide: sending patch series Jan Stancek
2012-07-09 10:17     ` Caspar Zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox