From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1SleMW-00063w-Ub for ltp-list@lists.sourceforge.net; Mon, 02 Jul 2012 11:00:12 +0000 Received: from mail-pb0-f47.google.com ([209.85.160.47]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1SleMT-0001mJ-34 for ltp-list@lists.sourceforge.net; Mon, 02 Jul 2012 11:00:12 +0000 Received: by pbbrq2 with SMTP id rq2so7135453pbb.34 for ; Mon, 02 Jul 2012 04:00:03 -0700 (PDT) Message-ID: <4FF17F0E.4030203@casparzhang.com> Date: Mon, 02 Jul 2012 18:59:26 +0800 From: Caspar Zhang MIME-Version: 1.0 References: <1341226390-16789-1-git-send-email-eguan@redhat.com> In-Reply-To: <1341226390-16789-1-git-send-email-eguan@redhat.com> Subject: Re: [LTP] [PATCH] syscalls/setxattr03: turn off immutable and append bit only if already set List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Eryu Guan Cc: ltp-list@lists.sourceforge.net On 07/02/2012 06:53 PM, Eryu Guan wrote: > > Turn off immutable and append-only attribute in cleanup() only if they > are already turned on. Otherwise bogus WARNING would fail test case when > no xattr support in fs or mount without user_xattr option. > > setxattr03 1 TCONF : No xattr support in fs or fs mounted without user_xattr option > setxattr03 2 TCONF : Remaining cases not appropriate for configuration > setxattr03 0 TWARN : Unset setxattr03immutable immutable failed: errno=EINVAL(22): Invalid argument > setxattr03 0 TWARN : Unset setxattr03appendonly append-only failed: errno=EINVAL(22): Invalid argument > > (The check-fd-value way is not perfect, but I think it's much more > easier and could cover the most common case.) > > Signed-off-by: Eryu Guan Looks good to me. Reviewed-by: Caspar Zhang ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list