From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Eryu Guan <eguan@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] syscalls/setxattr03: turn off immutable and append bit only if already set
Date: Mon, 02 Jul 2012 19:29:28 +0800 [thread overview]
Message-ID: <4FF18618.3040509@cn.fujitsu.com> (raw)
In-Reply-To: <1341226390-16789-1-git-send-email-eguan@redhat.com>
On 07/02/2012 06:53 PM, Eryu Guan wrote:
>
> Turn off immutable and append-only attribute in cleanup() only if they
> are already turned on. Otherwise bogus WARNING would fail test case when
> no xattr support in fs or mount without user_xattr option.
>
> setxattr03 1 TCONF : No xattr support in fs or fs mounted without user_xattr option
> setxattr03 2 TCONF : Remaining cases not appropriate for configuration
> setxattr03 0 TWARN : Unset setxattr03immutable immutable failed: errno=EINVAL(22): Invalid argument
> setxattr03 0 TWARN : Unset setxattr03appendonly append-only failed: errno=EINVAL(22): Invalid argument
>
> (The check-fd-value way is not perfect, but I think it's much more
> easier and could cover the most common case.)
pushed, thanks,
Wanlong Gao
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
> testcases/kernel/syscalls/setxattr/setxattr03.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>
>
>
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2012-07-02 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 10:53 [LTP] [PATCH] syscalls/setxattr03: turn off immutable and append bit only if already set Eryu Guan
2012-07-02 10:59 ` Caspar Zhang
2012-07-02 11:29 ` Wanlong Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF18618.3040509@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=eguan@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox