From: Caspar Zhang <caspar@casparzhang.com>
To: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] hugeshmat01: fix the wrong generated addr
Date: Mon, 09 Jul 2012 11:46:48 +0800 [thread overview]
Message-ID: <4FFA5428.50802@casparzhang.com> (raw)
In-Reply-To: <1341800766-5786-1-git-send-email-gaowanlong@cn.fujitsu.com>
On 07/09/2012 10:26 AM, Wanlong Gao wrote:
> The missed parentheses made the wrong operation.
>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Thanks for catching this. Pushed.
Caspar
> ---
> testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat01.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat01.c b/testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat01.c
> index 84a9121..2206dad 100644
> --- a/testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat01.c
> +++ b/testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat01.c
> @@ -128,8 +128,8 @@ int main(int ac, char **av)
> * address for TC[1]
> */
> if (i == 0 && addr != (void *)-1)
> - TC[1].addr = (void *)((unsigned long)addr &
> - ~(SHMLBA-1) + SHMLBA - 1);
> + TC[1].addr = (void *)(((unsigned long)addr &
> + ~(SHMLBA-1)) + SHMLBA - 1);
> if (shmdt(addr) == -1)
> tst_brkm(TBROK|TERRNO, cleanup, "shmdt");
> }
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
parent reply other threads:[~2012-07-09 3:53 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1341800766-5786-1-git-send-email-gaowanlong@cn.fujitsu.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFA5428.50802@casparzhang.com \
--to=caspar@casparzhang.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox