Re: [LTP] [PATCH/RFC] style-guide: sending patch series

[Caspar Zhang <caspar@casparzhang.com>]

On 07/09/2012 03:00 PM, Jan Stancek wrote:
> 
> 
> ----- Original Message -----
>> From: "Caspar Zhang" <caspar@casparzhang.com>
>> To: "Jan Stancek" <jstancek@redhat.com>
>> Cc: ltp-list@lists.sourceforge.net
>> Sent: Friday, 29 June, 2012 10:53:55 AM
>> Subject: Re: [LTP] [PATCH/RFC] style-guide: sending patch series
>>
>> On 06/29/2012 04:44 PM, Jan Stancek wrote:
>>> +git config format.numbered auto
>>> +git config sendemail.signoffbycc false
>>> +git config sendemail.suppresscc all
>>> +git config sendemail.suppressfrom true
>>> +git config sendemail.smtpserver "your.smtp.server"
>>> +git config sendemail.confirm always
>>
>> These lines look like not related to thread-shallow issue?
> 
> (sorry for late answer, was on holiday)
> 
> True, those are related to sending patch series with git send-email in general.
> I took 'best practices' from different mailing list as initial suggestion.

Okay. This caused a little confusion to me, I thought you were
suggesting use all configurations above as "shallow thread" style.

BTW, I don't think they[1] are necessary to put in style-guide.txt,
they're more likely to be tips instead.  i.e. we don't _require_ patch
contributor to avoid cc-ing to people in sign-off-by lines, nor require
they to suppress cc/from, blah, blah, etc.

Also, on my system, this line is not required either:

    +git config sendemail.thread false

once you have set this:

    +git config format.thread shallow

Whenever I enable or disable thread in sendemail section, the patchset
will be displayed as shallow format.

Thanks,
Caspar

[1] "they" refers to:
>>> +git config sendemail.signoffbycc false
>>> +git config sendemail.suppresscc all
>>> +git config sendemail.suppressfrom true
>>> +git config sendemail.smtpserver "your.smtp.server"
>>> +git config sendemail.confirm always

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list