From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Caspar Zhang <caspar@casparzhang.com>
Cc: LTP list <ltp-list@lists.sourceforge.net>,
Wang Sheng-Hui <shhuiw@gmail.com>
Subject: Re: [LTP] [PATCH 1/2] mm/vma01: consider topdown and bottomup allocation
Date: Mon, 09 Jul 2012 20:06:18 +0800 [thread overview]
Message-ID: <4FFAC93A.6080407@cn.fujitsu.com> (raw)
In-Reply-To: <1340609583-8300-1-git-send-email-caspar@casparzhang.com>
On 06/25/2012 03:33 PM, Caspar Zhang wrote:
> + if (topdown) {
> + x = get_end_addr(u);
> + printf("child : x = %p\n", x);
> + if (x == t + 3*ps)
> + exit(1);
> + else if (x == t && get_end_addr(x) == t + 3*ps)
> + exit(0);
> + } else {
> + x = get_end_addr(t);
> + printf("child : x = %p\n", x);
> + if (x == t + 6*ps)
> + exit(1);
> + else if (x == u && get_end_addr(x) == t + 6*ps)
> exit(0);
> }
Looks good to me.
Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
But why not use tst_resm(TINFO, ) instead?
Thanks,
Wanlong Gao
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-07-09 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 7:33 [LTP] [PATCH 1/2] mm/vma01: consider topdown and bottomup allocation Caspar Zhang
2012-06-25 7:33 ` [LTP] [PATCH 2/2] mm/vma01: create a bighole Caspar Zhang
2012-07-09 12:09 ` Wanlong Gao
2012-07-09 9:55 ` [LTP] [PATCH 1/2] mm/vma01: consider topdown and bottomup allocation Caspar Zhang
2012-07-09 12:06 ` Wanlong Gao [this message]
2012-07-09 12:27 ` Caspar Zhang
2012-07-09 13:11 ` Wanlong Gao
2012-07-11 1:00 ` Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFAC93A.6080407@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=caspar@casparzhang.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=shhuiw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox