From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Caspar Zhang <caspar@casparzhang.com>
Cc: LTP list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH 2/2] mm/lib: increase sleep time in ksm scanning
Date: Mon, 09 Jul 2012 21:10:30 +0800 [thread overview]
Message-ID: <4FFAD846.8060702@cn.fujitsu.com> (raw)
In-Reply-To: <4FFAD07D.6010703@casparzhang.com>
On 07/09/2012 08:37 PM, Caspar Zhang wrote:
> On 07/09/2012 07:32 PM, Wanlong Gao wrote:
>> On 07/09/2012 05:51 PM, Caspar Zhang wrote:
>>>
>>> for some systems under pressure, we've observed that sleeping 5 seconds
>>> is not sufficient for completing ksm scanning, to fix this, we should
>>> give ksmd more time to scan the mergable pages by increasing sleeping
>>> time to 10s.
>>
>> If 5s is not enough, isn't we waiting here already?
>
> Sorry, I'm not catching you... :-( the problem currently we encounter is that if 5s given, all ksm values (pages_sharing, pages_shared, etc) might remain the same between before and after sleeping, so the wait_ksmd function could exit. But in fact the kernel could be busy under pressure and it just needs more than 5s to merge the same page. Using 10s as polling interval can make sure if ksm values remains the same between each loop, it should indicates that ksmd has done scanning correctly.
>
Oops, it's a serious problem, so can we first wait for changing and then wait for not changing?
I'm afraid that hard coded sleep time can't do the right thing on some systems.
Thanks,
Wanlong Gao
> Thanks,
> Caspar
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-07-09 13:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 9:51 [LTP] [PATCH 1/2] mm/lib: ksm code style fixes Caspar Zhang
2012-07-09 9:51 ` [LTP] [PATCH 2/2] mm/lib: increase sleep time in ksm scanning Caspar Zhang
2012-07-09 10:11 ` Zhouping Liu
2012-07-09 11:32 ` Wanlong Gao
2012-07-09 12:37 ` Caspar Zhang
2012-07-09 13:10 ` Wanlong Gao [this message]
2012-07-09 14:15 ` Caspar Zhang
2012-07-09 15:51 ` Zhouping Liu
2012-07-10 0:25 ` Wanlong Gao
2012-07-09 10:08 ` [LTP] [PATCH 1/2] mm/lib: ksm code style fixes Zhouping Liu
2012-07-09 12:00 ` Wanlong Gao
2012-07-11 0:59 ` Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFAD846.8060702@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=caspar@casparzhang.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox