From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1SoECv-0001fK-D0 for ltp-list@lists.sourceforge.net; Mon, 09 Jul 2012 13:40:57 +0000 Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by sog-mx-4.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1SoECp-0000OO-DD for ltp-list@lists.sourceforge.net; Mon, 09 Jul 2012 13:40:57 +0000 Message-ID: <4FFAD885.5070107@cn.fujitsu.com> Date: Mon, 09 Jul 2012 21:11:33 +0800 From: Wanlong Gao MIME-Version: 1.0 References: <1340609583-8300-1-git-send-email-caspar@casparzhang.com> <4FFAC93A.6080407@cn.fujitsu.com> <4FFACE16.5080500@casparzhang.com> In-Reply-To: <4FFACE16.5080500@casparzhang.com> Subject: Re: [LTP] [PATCH 1/2] mm/vma01: consider topdown and bottomup allocation Reply-To: gaowanlong@cn.fujitsu.com List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Caspar Zhang Cc: LTP list , Wang Sheng-Hui On 07/09/2012 08:27 PM, Caspar Zhang wrote: > On 07/09/2012 08:06 PM, Wanlong Gao wrote: >> On 06/25/2012 03:33 PM, Caspar Zhang wrote: >>> + if (topdown) { >>> + x = get_end_addr(u); >>> + printf("child : x = %p\n", x); >>> + if (x == t + 3*ps) >>> + exit(1); >>> + else if (x == t && get_end_addr(x) == t + 3*ps) >>> + exit(0); >>> + } else { >>> + x = get_end_addr(t); >>> + printf("child : x = %p\n", x); >>> + if (x == t + 6*ps) >>> + exit(1); >>> + else if (x == u && get_end_addr(x) == t + 6*ps) >>> exit(0); >>> } >> >> Looks good to me. >> >> Reviewed-by: Wanlong Gao >> >> But why not use tst_resm(TINFO, ) instead? > > This is in child process. We'd avoid potential race on libltp between child and parent. (see style-guide.txt) OK, I see, thank you. Wanlong Gao > > Caspar > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list