Re: [LTP] [PATCH] Simple tests for cross memory attach (process_vm_[readv|writev] syscalls)

Caspar Zhang
2012-05-09T13:01:44Z

On 05/09/2012 08:46 PM, Christopher Yeoh wrote:
> Hi,
>
> Here are some patches which add testcases for cross memory attach (CMA)
> functionality which is included in more recent kernels. CMA adds two
> new syscalls, process_vm_readv and process_vm_writev. Man pages for
> these two syscalls were added in the man-pages-3.40 release.
>
> The testcases aren't really ready for inclusion as-is, but I thought
> they could do with some review now. One issue is that the syscall
> wrappers were not included in glibc until glibc 2.15 which not all
> distributions have picked up yet. For the testcases to compile I have a
> header file with some hard coded syscall numbers included (just for
> x86/powerpc atm, but more could be added). These numbers won't change
> in the future, but its an obviously ugly workaround.
>
> Is this a show stopper problem? Do I have to wait until more
> distributions have picked up glibc 2.15 (or at least backported the
> glibc syscall wrappers) before it can be added to LTP? Or should I use
> some other workaround - eg detect if the syscalls are defined on the
> system and just not attempt to build the test if they aren't?
>
> The testcases are not that extensive yet, just coverage of basic
> functionality.
>
> Regards,
>
> Chris
>

Hi Chris, thanks very much for the patch, I tried to backport your
testcases in http://ozlabs.org/~cyeoh/cma/ to LTP and composed an
unfinished version, then I was busy for other things. I'm happy to see
you can backport it by yourself :) There are some more new cma patches
(aims on testing retcode and errnos) sent by Jan Stancek (cc-ed) [1], I
think we need to discuss the testcase organization..

And I will review the testcases when I get more free time.

Thanks,
Caspar

[1]