public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: Petr Vorel <pvorel@suse.cz>, Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] Refactor timer_getoverrun test using new LTP API
Date: Fri, 9 Feb 2024 14:58:10 +0100	[thread overview]
Message-ID: <4dbe786e-0701-4e83-be4d-79176454ac44@suse.com> (raw)
In-Reply-To: <20240209135445.GA280250@pevik>

Hi Petr,

Yes, indeed it's not needed.
Can you please correct it before merge?

Thanks,
Andrea

On 2/9/24 14:54, Petr Vorel wrote:
> Hi Andrea,
>
>> +++ b/testcases/kernel/syscalls/timer_getoverrun/Makefile
>> @@ -5,4 +5,6 @@ top_srcdir		?= ../../../..
>>   include $(top_srcdir)/include/mk/testcases.mk
>> +LDLIBS			:= -lrt $(LDLIBS)
> Shouldn't we merge without -lrt, when we test only raw syscalls?
> If yes, it can be merged before merging.
>
> Otherwise LGTM.
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> Kind regards,
> Petr



-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-02-09 13:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 15:21 [LTP] [PATCH v3] Refactor timer_getoverrun test using new LTP API Andrea Cervesato
2024-02-09 13:54 ` Petr Vorel
2024-02-09 13:58   ` Andrea Cervesato via ltp [this message]
2024-02-09 14:02     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4dbe786e-0701-4e83-be4d-79176454ac44@suse.com \
    --to=ltp@lists.linux.it \
    --cc=andrea.cervesato@suse.com \
    --cc=andrea.cervesato@suse.de \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox