public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: "Lukáš Doktor" <ldoktor@redhat.com>
To: ltp-list@lists.sourceforge.net, Cleber Rosa <crosa@redhat.com>,
	vlee@twitter.com
Subject: Re: [LTP] Broken kernel/mem/ksm01 test
Date: Fri, 20 Jul 2012 15:06:31 +0200	[thread overview]
Message-ID: <500957D7.8000600@redhat.com> (raw)
In-Reply-To: <500952EC.6050504@redhat.com>

On 07/20/2012 02:45 PM, Lukáš Doktor wrote:
> Hi guys,
>
> I'm testing LTP-20120614 on Fedora 17 and it always stuck on ksm01 test.
>
> I went through sources and the problem is I have KSM already enabled 
> so the full_scans is a huge number. The function _group_check waits 
> till KSM does 3 * full_scans which in my case never ends (well it 
> might finish in a couple of years).
>
> To me it doesn't even make sense to wait 3 * full_scans as in the 
> first check it waits 1-2 seconds, in second check it waits few seconds 
> and it keeps growing further you goes.
>
> Would you please take look on this issue? I'd really appreciate it.
>
> Kind regards,
> Lukáš Doktor

Anyway if you think it should stay 3 * full_scans would you please at 
least reset the counter before the test start?

--- _mem.c      2012-07-20 13:39:20.351738873 +0200
+++ mem.c       2012-07-20 14:58:52.192157167 +0200
@@ -415,6 +415,7 @@ void create_same_memory(int size, int nu
                 }
         }
         tst_resm(TINFO, "KSM merging...");
+       write_file(PATH_KSM "run", "2");
         write_file(PATH_KSM "run", "1");
         snprintf(buf, BUFSIZ, "%ld", size * pages * num);
         write_file(PATH_KSM "pages_to_scan", buf);

I tested it and it works better (it fails, but at least it finishes). 
Anyway IMO it would be better to calculate the number of necessarily 
scans differently.

regards,
Lukáš

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2012-07-20 13:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20 12:45 [LTP] Broken kernel/mem/ksm01 test Lukáš Doktor
2012-07-20 13:06 ` Lukáš Doktor [this message]
2012-07-27  8:45   ` Caspar Zhang
2012-07-27 11:15 ` Zhouping Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500957D7.8000600@redhat.com \
    --to=ldoktor@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=vlee@twitter.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox