public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/execveat01: new test to verify execveat unlinked fd
Date: Wed, 12 Sep 2018 03:04:53 -0400 (EDT)	[thread overview]
Message-ID: <500978530.47285642.1536735893652.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CALLuPvqTLbtY1yFNFRgdTkf2keR1FoCF0RGrf_TREfWAvOy_JA@mail.gmail.com>


----- Original Message -----
> Jan Stancek <jstancek@redhat.com> 於 2018年9月11日 週二 下午11:24寫道:
> > We should fix this for release. If EINVAL is expected behaviour,
> > test should give PASS.
> >
> > It's failing with 4.18:
> >
> > tst_test.c:1063: INFO: Timeout per run is 0h 05m 00s
> > execveat03.c:71: FAIL: execveat() returned unexpected errno: EINVAL
> >
> 
> Hi Jan,
> The fix of original regression, ie. EINVAL returns in execveat03 test case,
> has been added to 4.18-stable and 4.14-stable:
> https://www.spinics.net/lists/stable/msg255906.html
> https://www.spinics.net/lists/stable/msg255724.html
> If give EINVAL as PASS, the case will PASS with or without the regression
> fix. I'm not sure which behavior of execveat03 is more appropriate.
> Please advise.

Hi Eddie,

thanks for the links. I think I confused myself with the comment in testcase.
I thought EINVAL is expected behavior with the fix.

For now, I only added comment with commit id of the fix to testcase.

Thanks,
Jan

> 
> Thanks,
> Eddie
> 

      reply	other threads:[~2018-09-12  7:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01  8:17 [LTP] [PATCH v2] syscalls/execveat01: new test to verify execveat unlinked fd Eddie.Horng
2018-08-01 11:17 ` Li Wang
2018-08-01 12:53   ` Cyril Hrubis
2018-08-03  9:32   ` Eddie Horng
2018-08-06  9:26     ` Li Wang
2018-08-08 14:41       ` Cyril Hrubis
2018-08-08 14:48         ` Cyril Hrubis
2018-08-09  9:04 ` Cyril Hrubis
2018-08-10  9:32   ` Eddie Horng
2018-09-11 15:24 ` Jan Stancek
2018-09-12  1:44   ` Eddie Horng
2018-09-12  7:04     ` Jan Stancek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500978530.47285642.1536735893652.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox