[LTP] [PATCH] aio_suspend/3-1: cancel the aio_write operations

[LTP] [PATCH] aio_suspend/3-1: cancel the aio_write operations

[Kang Kai]

After aio_suspend, call aio_cancel to cancel other aio_write operations
then wait them to canceld or complete.

If don't do that, it fails with "Segmentation fault" on routerstation(mips)
board randomly about in 1000 continuous test. The reason may be some
aio_writes don't complete before close the file, that cause some resouse
don't be released and finally cause segment fault.

Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
 .../conformance/interfaces/aio_suspend/3-1.c       |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/3-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/3-1.c
index 15120e1..49d204a 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/3-1.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/3-1.c
@@ -87,6 +87,21 @@ int main()
 		exit(PTS_FAIL);
 	}
 
+	if (aio_cancel(fd, NULL) == -1) {
+		printf(TNAME " Error at aio_cancel(): %s\n", strerror(errno));
+		exit(PTS_FAIL);
+	}
+
+
+	while (1) {
+		for (i = 0; i < NAIOCB; ++i) {
+			if (aio_error(&aiocb[i]) == EINPROGRESS)
+				break;
+		}
+		if (i == NAIOCB)
+			break;
+	}
+
 	close(fd);
 	printf("Test PASSED\n");
 	return PTS_PASS;
-- 
1.7.5.4


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] aio_suspend/3-1: cancel the aio_write operations

[Kang Kai]

On 2012年07月26日 10:22, Kang Kai wrote:
> After aio_suspend, call aio_cancel to cancel other aio_write operations
> then wait them to canceld or complete.
>
> If don't do that, it fails with "Segmentation fault" on routerstation(mips)
> board randomly about in 1000 continuous test. The reason may be some
> aio_writes don't complete before close the file, that cause some resouse
> don't be released and finally cause segment fault.

Hi,

Would anybody like to review this patch for me?

Thanks,

Kai
> Signed-off-by: Kang Kai<kai.kang@windriver.com>
> ---
>   .../conformance/interfaces/aio_suspend/3-1.c       |   15 +++++++++++++++
>   1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/3-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/3-1.c
> index 15120e1..49d204a 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/3-1.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/3-1.c
> @@ -87,6 +87,21 @@ int main()
>   		exit(PTS_FAIL);
>   	}
>
> +	if (aio_cancel(fd, NULL) == -1) {
> +		printf(TNAME " Error at aio_cancel(): %s\n", strerror(errno));
> +		exit(PTS_FAIL);
> +	}
> +
> +
> +	while (1) {
> +		for (i = 0; i<  NAIOCB; ++i) {
> +			if (aio_error(&aiocb[i]) == EINPROGRESS)
> +				break;
> +		}
> +		if (i == NAIOCB)
> +			break;
> +	}
> +
>   	close(fd);
>   	printf("Test PASSED\n");
>   	return PTS_PASS;


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] aio_suspend/3-1: cancel the aio_write operations

[Wanlong Gao]

On 07/26/2012 10:22 AM, Kang Kai wrote:
> After aio_suspend, call aio_cancel to cancel other aio_write operations
> then wait them to canceld or complete.
> 
> If don't do that, it fails with "Segmentation fault" on routerstation(mips)
> board randomly about in 1000 continuous test. The reason may be some
> aio_writes don't complete before close the file, that cause some resouse
> don't be released and finally cause segment fault.
> 
> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> ---
>  .../conformance/interfaces/aio_suspend/3-1.c       |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
> 
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/3-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/3-1.c
> index 15120e1..49d204a 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/3-1.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_suspend/3-1.c
> @@ -87,6 +87,21 @@ int main()
>  		exit(PTS_FAIL);
>  	}
>  
> +	if (aio_cancel(fd, NULL) == -1) {
> +		printf(TNAME " Error at aio_cancel(): %s\n", strerror(errno));
> +		exit(PTS_FAIL);
> +	}

Try to cancel the pending aio seems useless, how about waiting aios until completed?
Can you test like below?
	
	for (i = 0; i < NAIOCB; i++) {
		do {
			usleep(10000);
			ret = aio_error(&aiocb[i]);
		} while (ret == EINPROGRESS);
		if (ret < 0) {
			printf(TNAME " Error at aio_error() : %s\n", strerror(ret));
			exit(PTS_FAIL);
		}
	}

Thanks,
Wanlong Gao

> +
> +
> +	while (1) {
> +		for (i = 0; i < NAIOCB; ++i) {
> +			if (aio_error(&aiocb[i]) == EINPROGRESS)
> +				break;
> +		}
> +		if (i == NAIOCB)
> +			break;
> +	}
> +
>  	close(fd);
>  	printf("Test PASSED\n");
>  	return PTS_PASS;
> 


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list