[LTP] [PATCH] ltp_signal.h: Remove inline keyword from handler_h.

[LTP] [PATCH] ltp_signal.h: Remove inline keyword from handler_h.

[Vinson Lee]

This patch fixes this build error with clang.

testcases/kernel/syscalls/rt_sigaction/../../../../include/ltp_signal.h:85: undefined reference to `handler_h'

Signed-off-by: Vinson Lee <vlee@twitter.com>
---
 include/ltp_signal.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/ltp_signal.h b/include/ltp_signal.h
index 1ac6f70..093059f 100644
--- a/include/ltp_signal.h
+++ b/include/ltp_signal.h
@@ -69,7 +69,7 @@ struct kernel_sigaction {
 
 void (*restore_rt) (void);
 
-inline void
+void
 handler_h (int signal)
 {
 	return;
-- 
1.7.9.5


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] ltp_signal.h: Remove inline keyword from handler_h.

[Wanlong Gao]

On 08/04/2012 06:29 AM, Vinson Lee wrote:
> This patch fixes this build error with clang.
> 
> testcases/kernel/syscalls/rt_sigaction/../../../../include/ltp_signal.h:85: undefined reference to `handler_h'

If you wanna build LTP with LLVM, why not make out "a path for LLVM building" and send
out it. I think this one line change can't do everything for LLVM building, although
untested. right?

Thanks,
Wanlong Gao

> 
> Signed-off-by: Vinson Lee <vlee@twitter.com>
> ---
>  include/ltp_signal.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/ltp_signal.h b/include/ltp_signal.h
> index 1ac6f70..093059f 100644
> --- a/include/ltp_signal.h
> +++ b/include/ltp_signal.h
> @@ -69,7 +69,7 @@ struct kernel_sigaction {
>  
>  void (*restore_rt) (void);
>  
> -inline void
> +void
>  handler_h (int signal)
>  {
>  	return;
> 


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] ltp_signal.h: Remove inline keyword from handler_h.

[Vinson Lee]

On Sun, Aug 5, 2012 at 6:42 PM, Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote:
> On 08/04/2012 06:29 AM, Vinson Lee wrote:
>> This patch fixes this build error with clang.
>>
>> testcases/kernel/syscalls/rt_sigaction/../../../../include/ltp_signal.h:85: undefined reference to `handler_h'
>
> If you wanna build LTP with LLVM, why not make out "a path for LLVM building" and send
> out it. I think this one line change can't do everything for LLVM building, although
> untested. right?
>
> Thanks,
> Wanlong Gao
>

This was the only build error with I saw with clang. This one change
fixes the build with clang.

It's a C99 error which would probably occur with gcc -std=c99 as well.
http://clang.llvm.org/compatibility.html#inline


>>
>> Signed-off-by: Vinson Lee <vlee@twitter.com>
>> ---
>>  include/ltp_signal.h |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/ltp_signal.h b/include/ltp_signal.h
>> index 1ac6f70..093059f 100644
>> --- a/include/ltp_signal.h
>> +++ b/include/ltp_signal.h
>> @@ -69,7 +69,7 @@ struct kernel_sigaction {
>>
>>  void (*restore_rt) (void);
>>
>> -inline void
>> +void
>>  handler_h (int signal)
>>  {
>>       return;
>>
>

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] ltp_signal.h: Remove inline keyword from handler_h.

[Wanlong Gao]

On 08/07/2012 12:55 AM, Vinson Lee wrote:
> On Sun, Aug 5, 2012 at 6:42 PM, Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote:
>> On 08/04/2012 06:29 AM, Vinson Lee wrote:
>>> This patch fixes this build error with clang.
>>>
>>> testcases/kernel/syscalls/rt_sigaction/../../../../include/ltp_signal.h:85: undefined reference to `handler_h'
>>
>> If you wanna build LTP with LLVM, why not make out "a path for LLVM building" and send
>> out it. I think this one line change can't do everything for LLVM building, although
>> untested. right?
>>
>> Thanks,
>> Wanlong Gao
>>
> 
> This was the only build error with I saw with clang. This one change
> fixes the build with clang.
> 
> It's a C99 error which would probably occur with gcc -std=c99 as well.
> http://clang.llvm.org/compatibility.html#inline

I saw that "Change add to a static inline function. 
This is usually the right solution if only one translation
unit needs to use the function. static inline functions are
always resolved within the translation unit, so you won't have
to add a non-inline definition of the function elsewhere in your program."

So, why not just change it to "static inline" to resolve this?

Thanks,
Wanlong Gao

> 
> 
>>>
>>> Signed-off-by: Vinson Lee <vlee@twitter.com>
>>> ---
>>>  include/ltp_signal.h |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/ltp_signal.h b/include/ltp_signal.h
>>> index 1ac6f70..093059f 100644
>>> --- a/include/ltp_signal.h
>>> +++ b/include/ltp_signal.h
>>> @@ -69,7 +69,7 @@ struct kernel_sigaction {
>>>
>>>  void (*restore_rt) (void);
>>>
>>> -inline void
>>> +void
>>>  handler_h (int signal)
>>>  {
>>>       return;
>>>
>>
> 


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] ltp_signal.h: Remove inline keyword from handler_h.

[chrubis]

Hi!
> I saw that "Change add to a static inline function. 
> This is usually the right solution if only one translation
> unit needs to use the function. static inline functions are
> always resolved within the translation unit, so you won't have
> to add a non-inline definition of the function elsewhere in your program."
> 
> So, why not just change it to "static inline" to resolve this?

Interestingly enough, the function is passed via pointer so compiler
couldn't inline it at all, I wonder why there was the inline in the
first place...

I've removed the inline added static and confirmed that it builds with
clang 3.1 on x86_64.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] ltp_signal.h: Remove inline keyword from handler_h.

[chrubis]

Hi!
> diff --git a/include/ltp_signal.h b/include/ltp_signal.h
> index 1ac6f70..093059f 100644
> --- a/include/ltp_signal.h
> +++ b/include/ltp_signal.h
> @@ -69,7 +69,7 @@ struct kernel_sigaction {
>  
>  void (*restore_rt) (void);
>  
> -inline void
> +void
>  handler_h (int signal)
>  {
>  	return;

I've just commited similar patch to this and added your signed-of-by.

Thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list