From: Caspar Zhang <caspar@casparzhang.com>
To: Jan Stancek <jstancek@redhat.com>
Cc: LTP List <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH v2 2/2] mm: use new numa_helper
Date: Mon, 06 Aug 2012 16:33:16 +0800 [thread overview]
Message-ID: <501F814C.7090608@casparzhang.com> (raw)
In-Reply-To: <431447144.362760.1344240993345.JavaMail.root@redhat.com>
On 08/06/2012 04:16 PM, Jan Stancek wrote:
> Hi Caspar,
>
> There seems to be a typo in vma02.c and vma04.c: "err = -3"
>
> + } else {
>
> + err = get_allowed_nodes(NH_MEMS|NH_MEMS, 1, &node);
>
> + if (err = -3)
>
> + tst_brkm(TCONF, NULL, "requires at least one node.");
>
> also in vma04.c, ret variable is not used, so perhaps it can be removed:
> + int lc, node, ret, err;
Oops... Thanks for reviewing! a V3 will come out soon.
Caspar
>
> Regards,
> Jan
>
> ----- Original Message -----
>> From: "Caspar Zhang" <caspar@casparzhang.com>
>> To: "LTP List" <ltp-list@lists.sourceforge.net>
>> Sent: Monday, 6 August, 2012 8:30:51 AM
>> Subject: [LTP] [PATCH v2 2/2] mm: use new numa_helper
>>
>>
>> This patch makes the tests in mem/ dir use numa_helper in
>> libkerntest.
>>
>> Signed-off-by: Caspar Zhang <caspar@casparzhang.com>
>> ---
>> testcases/kernel/mem/cpuset/Makefile | 1 +
>> testcases/kernel/mem/cpuset/cpuset01.c | 16 ++++----
>> testcases/kernel/mem/hugetlb/Makefile.inc | 1 +
>> testcases/kernel/mem/hugetlb/hugemmap/Makefile | 1 +
>> testcases/kernel/mem/include/mem.h | 2 +-
>> testcases/kernel/mem/ksm/Makefile | 1 +
>> testcases/kernel/mem/ksm/ksm02.c | 9 ++--
>> testcases/kernel/mem/ksm/ksm04.c | 9 ++--
>> testcases/kernel/mem/lib/Makefile | 1 +
>> testcases/kernel/mem/lib/mem.c | 50
>> ++++++++++++++++--------
>> testcases/kernel/mem/oom/Makefile | 1 +
>> testcases/kernel/mem/oom/oom02.c | 4 --
>> testcases/kernel/mem/oom/oom04.c | 4 --
>> testcases/kernel/mem/swapping/Makefile | 1 +
>> testcases/kernel/mem/thp/Makefile | 1 +
>> testcases/kernel/mem/tunable/Makefile | 1 +
>> testcases/kernel/mem/vma/Makefile | 3 +-
>> testcases/kernel/mem/vma/vma02.c | 19 ++++++---
>> testcases/kernel/mem/vma/vma04.c | 11 ++++-
>> 19 files changed, 81 insertions(+), 55 deletions(-)
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond.
>> Discussions
>> will include endpoint security, mobile security and the latest in
>> malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Ltp-list mailing list
>> Ltp-list@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/ltp-list
>>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-08-06 8:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 6:30 [LTP] [PATCH v2 1/2] numa_helper: move to libkerntest Caspar Zhang
2012-08-06 6:30 ` [LTP] [PATCH v2 2/2] mm: use new numa_helper Caspar Zhang
2012-08-06 8:16 ` Jan Stancek
2012-08-06 8:33 ` Caspar Zhang [this message]
2012-08-06 8:38 ` [LTP] [PATCH v3 " Caspar Zhang
2012-08-06 9:32 ` Jan Stancek
2012-08-06 9:39 ` [LTP] [PATCH v2 1/2] numa_helper: move to libkerntest Jan Stancek
2012-08-06 11:58 ` Caspar Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501F814C.7090608@casparzhang.com \
--to=caspar@casparzhang.com \
--cc=jstancek@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox