Re: [LTP] [PATCH 1/6] /lib/tst_tmpdir indentation and coding style fixes

Caspar Zhang
2012-07-18T13:51:38Z

On 07/18/2012 09:32 PM, marios.makris wrote:
> On 18 July 2012 11:20, Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote:
>> On 07/13/2012 11:51 PM, Marios Makris wrote:
>>> Identation and coding style fixes as well as moved the function descriptions
>>> to the header file (/include/test.h)
>>>
>>> Signed-off-by: Marios Makris <marios.makris@gmail.com>
>>> ---
>>> include/test.h | 26 +++++++++++++++
>>> lib/tst_tmpdir.c | 97 ++++++++++++++++++------------------------------------
>>> 2 files changed, 58 insertions(+), 65 deletions(-)
>>>
>>> diff --git a/include/test.h b/include/test.h
>>> index 033fdbc..934585e 100644
>>> --- a/include/test.h
>>> +++ b/include/test.h
>>> @@ -201,8 +201,34 @@ extern int Tst_count;
>>> void tst_sig(int fork_flag, void (*handler)(), void (*cleanup)());
>>>
>>> /* lib/tst_tmpdir.c */
>>> +
>>> +/* tst_tmpdir()
>>> + *
>>> + * Create a unique temporary directory and chdir() to it. It expects the caller
>>
>> It's better to keep the comments lines within 73 characters.
>>
>> Thanks,
>> Wanlong Gao
>>
>
> Well i thought that the line limit was 80 characters(columns) ?
>
> Thanks
>

I think it's 80 characters. (it should be OK if checkpatch.pl doesn't
complain...)

Caspar