Re: [LTP] [PATCH resend 5/6] mm: use new numa_helper

Jan Stancek
2012-08-10T08:24:33Z

----- Original Message -----
> From: "Zhouping Liu" <zliu@redhat.com>
> To: "Caspar Zhang" <caspar@casparzhang.com>
> Cc: "LTP List" <ltp-list@lists.sourceforge.net>
> Sent: Friday, 10 August, 2012 10:02:01 AM
> Subject: Re: [LTP] [PATCH resend 5/6] mm: use new numa_helper
>

> > -» return·nnodes;
> > +» ret·=·get_allowed_nodes(NH_MEMS|NH_CPUS,·1,·&nd1);
>
> Caspar, I found get_a_numa_node always return the first node id,
> which
> will make all cases called the function
> only run in the first node, I don't think it's a good way, it
> decrease
> the coverage.

We had a discussion with Caspar on this topic:
http://article.gmane.org/gmane.linux.ltp/16495

Can you explain why a specific node matters here?

Regards,
Jan

>
> we should prefer to run cases on the second node, we can chose the
> first
> only if it just only has
> one node with NH_MEMS|NH_CPUS. do you think so?
>
> and others is good for me.
>
> Thanks,
> Zhouping