Re: [LTP] [PATCH resend 5/6] mm: use new numa_helper

Caspar Zhang
2012-08-10T08:47:27Z

On 08/10/2012 04:02 PM, Zhouping Liu wrote:
> Caspar, I found get_a_numa_node always return the first node id, which
> will make all cases called the function
> only run in the first node, I don't think it's a good way, it decrease
> the coverage.
>
> we should prefer to run cases on the second node, we can chose the first
> only if it just only has
> one node with NH_MEMS|NH_CPUS. do you think so?
>
> and others is good for me.

Jan and I discussed this issue before:

On 08/01/2012 06:23 PM, Jan Stancek wrote:
>>> >> >Do you think it will affect test coverage if we always test first
>>> >> >node?
> > I'm leaning towards "no". I'm assuming oom01 is using default mem
policy,
> > so it can allocate memory from any node (including second one).

And I agree with this opinion. What you think?

Caspar