public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: Kang Kai <Kai.Kang@windriver.com>
Cc: ltp-list@lists.sourceforge.net,
	Zhenfeng Zhao <Zhenfeng.Zhao@windriver.com>
Subject: Re: [LTP] [PATCH] pthread_detach/4-3: workaround for segment fault
Date: Wed, 22 Aug 2012 16:20:21 +0200	[thread overview]
Message-ID: <5034EAA5.3020405@redhat.com> (raw)
In-Reply-To: <40249568.8900482.1345625939805.JavaMail.root@redhat.com>

On 08/22/2012 10:58 AM, Jan Stancek wrote:
> 
> 
> ----- Original Message -----
>> From: "Kang Kai" <Kai.Kang@windriver.com>
>> To: "Jan Stancek" <jstancek@redhat.com>
>> Cc: gaowanlong@cn.fujitsu.com, ltp-list@lists.sourceforge.net, "Zhenfeng Zhao" <Zhenfeng.Zhao@windriver.com>
>> Sent: Wednesday, 22 August, 2012 10:28:59 AM
>> Subject: Re: [LTP] [PATCH] pthread_detach/4-3: workaround for segment fault
> 
>> Hi Jan,
>>
>>> Is the above output from mips or x86_64?
>>> Are you running it as root user?
>>
>> This was tested on x86_64 with unprivileged  user. I retest it with
>> root
>> and test passes.
> 
> Your unprivileged user is hitting some resource limit, I'd be interested
> to see how many threads are actually running at the same time. 
> 
>> It passes on routerstation(mips) with your patch too.
>> So it looks like a race condition issue about stack attribute between
>> threads, right?
> 
> I think so. We can try different way of signalling when threaded() is done
> and try it again with all scenarios.

I think this testcase is broken in more than 1 way. At least on my setup, I don't see
a single pthread_detach() while signals are firing - which is exactly goal of this test.

With following change:

diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/4-3.c b/testcases/open_posix_testsuite/conforman
index dfa6e19..48e1343 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/4-3.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_detach/4-3.c
@@ -277,6 +276,7 @@ int main(int argc, char *argv[])
                do_it1 = 0;
        } while (do_it1);
 
+       output("  %d thread detached while signals were firing.\n", count_ope);
        sleep(1);
 
        do {

I get:
[16:11:23]  1 thread detached while signals are firing.
[16:11:24]Test executed successfully.
[16:11:24]  77865 thread detached.

and that reported "1" is how many threads attempted to call pthread_detach, not how many actually
succeeded. Signals are firing so frequently that threaded() can't progress at all.

Regards,
Jan

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2012-08-22 14:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-21 10:35 [LTP] [PATCH] pthread_detach/4-3: workaround for segment fault Jan Stancek
2012-08-22  2:29 ` Kang Kai
2012-08-22  7:06   ` Jan Stancek
2012-08-22  8:28     ` Kang Kai
2012-08-22  8:58       ` Jan Stancek
2012-08-22 14:20         ` Jan Stancek [this message]
2012-08-23  6:21           ` Kang Kai
2012-08-23  7:09             ` Jan Stancek
2012-08-23 11:07               ` Jan Stancek
2012-08-24  2:46                 ` Kang Kai
2012-08-28  8:37                   ` Jan Stancek
2012-08-29  8:57                     ` Kang Kai
2012-08-29  9:21                       ` Jan Stancek
  -- strict thread matches above, loose matches on Subject: below --
2012-08-14  9:00 Kang Kai
2012-08-18 22:58 ` Wanlong Gao
2012-08-20  1:39   ` Kang Kai
2012-08-20  2:01     ` Wanlong Gao
2012-08-20  2:21       ` Kang Kai
2012-08-21  1:31         ` Kang Kai
2012-08-21  1:35           ` Wanlong Gao
2012-08-21  9:24             ` Kang Kai
2012-08-21  9:24               ` Wanlong Gao
2012-08-21  9:45               ` Jan Stancek
2012-08-21  9:59                 ` Kang Kai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5034EAA5.3020405@redhat.com \
    --to=jstancek@redhat.com \
    --cc=Kai.Kang@windriver.com \
    --cc=Zhenfeng.Zhao@windriver.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox