public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: ZhouPing Liu <zliu@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] Set tunable value of min_free_kbytes lower
Date: Wed, 29 Aug 2012 16:29:52 +0800	[thread overview]
Message-ID: <503DD300.309@cn.fujitsu.com> (raw)
In-Reply-To: <503CBEBF.2040101@redhat.com>


> yes, you are right.
> I tried to fork several processes to hog memory, but I don't think it's 
> a better way, so a good solution(I think) is included in below patch.
> 
>>
>> And we can also patch the overflow issue which I mentioned before:
>>
>> The type of total_mem "unsigned long" is not suitable with nowadays
>> memory ,it will overflow(with i386) in line 177:map_count = total_mem
>> *
>> KB / MAP_SIZE and the value of map_count is not correct.
>> Using "unsigned long long" could fix this issue.
> 
> after re-check the code, I found map_count was not necessary, so I 
> removed it,
> at the same time, it fixed your the overflow issue.
> 
> please review the patch again, if you agree the fix, I will send a 
> formal patch set in new subject:


So, please, thank you.

Wanlong Gao


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  parent reply	other threads:[~2012-08-29  8:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23  6:43 [LTP] [PATCH] Set tunable value of min_free_kbytes lower shuang.qiu
2012-08-23  8:59 ` Zhouping Liu
2012-08-23  9:00   ` Wanlong Gao
2012-08-24  8:11 ` Zhouping Liu
2012-08-24 10:18   ` Shuang Qiu
2012-08-24 13:48     ` Zhouping Liu
2012-08-27  3:03       ` Shuang Qiu
2012-08-27  5:01         ` Zhouping Liu
2012-08-27  5:16   ` Zhouping Liu
2012-08-28  3:11     ` Shuang Qiu
2012-08-28 12:51       ` ZhouPing Liu
2012-08-29  8:08         ` Shuang Qiu
2012-08-29  8:29         ` Wanlong Gao [this message]
2012-08-29  8:56           ` Zhouping Liu
2012-08-29 14:03     ` Zhouping Liu
2012-08-30  2:53       ` Shuang Qiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503DD300.309@cn.fujitsu.com \
    --to=gaowanlong@cn.fujitsu.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=zliu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox