[LTP] [PATCH 1/3] tunable: reduce the min_free_kbytes tunable

[LTP] [PATCH 1/3] tunable: reduce the min_free_kbytes tunable

[Zhouping Liu]

Setting min_free_kbytes too high will cause system hangs,
especially in i386 arch, using less than 5% of total memory
can avoid it, so choose %5 of free memory or 2% of total memory.
Thanks Shuang pointed out it.

also, in order to enlarge the coverage, the patch adds a new
case item: 2 * default tunable

Signed-off-by: Zhouping Liu <zliu@redhat.com>
Signed-off-by: Shuang Qiu <shuang.qiu@oracle.com>
---
 testcases/kernel/mem/tunable/min_free_kbytes.c | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/testcases/kernel/mem/tunable/min_free_kbytes.c b/testcases/kernel/mem/tunable/min_free_kbytes.c
index 00ead04..f8288ec 100644
--- a/testcases/kernel/mem/tunable/min_free_kbytes.c
+++ b/testcases/kernel/mem/tunable/min_free_kbytes.c
@@ -10,7 +10,8 @@
  * the current free memory with the tunable value repeatedly.
  *
  * a) default min_free_kbytes with all overcommit memory policy
- * b) half of mem_free with all overcommit memory policy
+ * b) 2x default value with all overcommit memory policy
+ * c) 5% of MemFree or %2 MemTotal with all overcommit memory policy
  *
  ********************************************************************
  * Copyright (C) 2012 Red Hat, Inc.
@@ -115,20 +116,27 @@ int main(int argc, char *argv[])
 static void test_tune(unsigned long overcommit_policy)
 {
 	int status;
-	int pid[2];
+	int pid[3];
 	int ret, i;
-	unsigned long tune, memfree;
+	unsigned long tune, memfree, memtotal;
 
 	set_sys_tune("overcommit_memory", overcommit_policy, 1);
 
-	for (i = 0; i < 2; i++) {
+	for (i = 0; i < 3; i++) {
 		/* case1 */
 		if (i == 0)
 			set_sys_tune("min_free_kbytes", default_tune, 1);
 		/* case2 */
-		else {
+		else if (i == 1) {
+			set_sys_tune("min_free_kbytes", 2 * default_tune, 1);
+		/* case3 */
+		} else {
 			memfree = read_meminfo("MemFree:");
-			tune = memfree / 2;
+			memtotal = read_meminfo("MemTotal:");
+			tune = memfree / 20;
+			if (tune > (memtotal / 50))
+				tune = memtotal / 50;
+
 			set_sys_tune("min_free_kbytes", tune, 1);
 		}
 
-- 
1.7.11.2


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 2/3] tunable/min_free_kbytes: remove map_count args

[Zhouping Liu]

as the type of total_mem is 'unsigned long', inside
32-bit system, it will overflow in this sentence
  map_count = total_mem * KB / MAP_SIZE

e.g: if total_mem > 4194304, 'total_mem*KB' will > ULONG_MAX.

after re-cehck the code, I found map_count was not necessary,
and removing it can fix the overflow issue.

Reported-by: Shuang Qiu <shuang.qiu@oracle.com>
Signed-off-by: Zhouping Liu <zliu@redhat.com>
---
 testcases/kernel/mem/tunable/min_free_kbytes.c | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/testcases/kernel/mem/tunable/min_free_kbytes.c b/testcases/kernel/mem/tunable/min_free_kbytes.c
index f8288ec..dde182c 100644
--- a/testcases/kernel/mem/tunable/min_free_kbytes.c
+++ b/testcases/kernel/mem/tunable/min_free_kbytes.c
@@ -177,31 +177,23 @@ static void test_tune(unsigned long overcommit_policy)
 
 static int eatup_mem(unsigned long overcommit_policy)
 {
-	int map_count, i;
 	int ret = 0;
 	unsigned long memfree;
-	void **addrs;
-
-	map_count = total_mem * KB / MAP_SIZE;
-	addrs = (void **)malloc(map_count * sizeof(void *));
-	if (addrs == NULL) {
-		perror("malloc");
-		return -1;
-	}
+	void *addrs;
 
 	memfree = read_meminfo("MemFree:");
 	printf("memfree is %lu kB before eatup mem\n", memfree);
-	for (i = 0; i < map_count; i++) {
-		addrs[i] = mmap(NULL, MAP_SIZE, PROT_READ|PROT_WRITE,
+	while (1) {
+		addrs = mmap(NULL, MAP_SIZE, PROT_READ|PROT_WRITE,
 		    MAP_ANONYMOUS|MAP_PRIVATE, -1, 0);
-		if (addrs[i] == MAP_FAILED) {
+		if (addrs == MAP_FAILED) {
 			if (overcommit_policy != 1 && errno != ENOMEM) {
 				perror("mmap");
 				ret = -1;
 			}
 			break;
 		}
-		memset(addrs[i], i, MAP_SIZE);
+		memset(addrs, 1, MAP_SIZE);
 	}
 	memfree = read_meminfo("MemFree:");
 	printf("memfree is %lu kB after eatup mem\n", memfree);
-- 
1.7.11.2


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 3/3] tunable/min_free_kbytes: add 32-bit system limit

[Zhouping Liu]

in 32-bit system, one process only allocate 3Gb memory at
least, even though there are enough memory and setting
overcommit_memory=1, the porcess always exit when it arrives
in 3Gb memory.

the patch use '__WORDSIZE' macro to avoid the incorrect 'TFAIL'
without the patch:
 ---- snip ----
 min_free_kbytes    0  TINFO  :  set overcommit_memory to 1
 min_free_kbytes    0  TINFO  :  set min_free_kbytes to 3794
 memfree is 15478420 kB before eatup mem
 memfree is 12333408 kB after eatup mem
 min_free_kbytes    3  TFAIL  :  child unexpectedly failed: 0
 min_free_kbytes    0  TINFO  :  set min_free_kbytes to 7588
 ---- snip ----

after applying the patch:
 ---- snip ----
 min_free_kbytes    0  TINFO  :  set overcommit_memory to 1
 min_free_kbytes    0  TINFO  :  set min_free_kbytes to 3794
 memfree is 15478420 kB before eatup mem
 memfree is 12333408 kB after eatup mem
 min_free_kbytes    0  TINFO  :  Child can't allocate >3Gb memory in 32bit system
 min_free_kbytes    0  TINFO  :  set min_free_kbytes to 7588
 ---- snip ----

Reported-by: Shuang Qiu <shuang.qiu@oracle.com>
Signed-off-by: Zhouping Liu <zliu@redhat.com>
---
 testcases/kernel/mem/tunable/min_free_kbytes.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/testcases/kernel/mem/tunable/min_free_kbytes.c b/testcases/kernel/mem/tunable/min_free_kbytes.c
index dde182c..873b807 100644
--- a/testcases/kernel/mem/tunable/min_free_kbytes.c
+++ b/testcases/kernel/mem/tunable/min_free_kbytes.c
@@ -158,8 +158,19 @@ static void test_tune(unsigned long overcommit_policy)
 				    "child unexpectedly failed: %d", status);
 		} else if (overcommit_policy == 1) {
 			if (!WIFSIGNALED(status) || WTERMSIG(status) != SIGKILL)
+#if __WORDSIZE == 32
+			{
+				if (total_mem < 3145728UL)
+#endif
 				tst_resm(TFAIL,
 				    "child unexpectedly failed: %d", status);
+#if __WORDSIZE == 32
+	/* in 32-bit system, a process allocate about 3Gb memory at most */
+				else
+					tst_resm(TINFO, "Child can't allocate "
+					    ">3Gb memory in 32bit system");
+			}
+#endif
 		} else {
 			if (WIFEXITED(status)) {
 				if (WEXITSTATUS(status) != 0) {
-- 
1.7.11.2


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 3/3] tunable/min_free_kbytes: add 32-bit system limit

[Zhouping Liu]

----- Original Message -----
> From: "Zhouping Liu" <zliu@redhat.com>
> To: "LTP list" <ltp-list@lists.sourceforge.net>
> Sent: Wednesday, August 29, 2012 8:43:59 PM
> Subject: [LTP] [PATCH 3/3] tunable/min_free_kbytes: add 32-bit system limit
> 
> in 32-bit system, one process only allocate 3Gb memory at
> least, even though there are enough memory and setting

I'm sorry that the above sentences has a typo, 'at least' should be
changed as 'at most', so maintainers, please correct it if you apply the patch.
please let me know if you need me send a V2.

Thanks,
Zhouping

> overcommit_memory=1, the porcess always exit when it arrives
> in 3Gb memory.
> 
> the patch use '__WORDSIZE' macro to avoid the incorrect 'TFAIL'
> without the patch:
>  ---- snip ----
>  min_free_kbytes    0  TINFO  :  set overcommit_memory to 1
>  min_free_kbytes    0  TINFO  :  set min_free_kbytes to 3794
>  memfree is 15478420 kB before eatup mem
>  memfree is 12333408 kB after eatup mem
>  min_free_kbytes    3  TFAIL  :  child unexpectedly failed: 0
>  min_free_kbytes    0  TINFO  :  set min_free_kbytes to 7588
>  ---- snip ----
> 
> after applying the patch:
>  ---- snip ----
>  min_free_kbytes    0  TINFO  :  set overcommit_memory to 1
>  min_free_kbytes    0  TINFO  :  set min_free_kbytes to 3794
>  memfree is 15478420 kB before eatup mem
>  memfree is 12333408 kB after eatup mem
>  min_free_kbytes    0  TINFO  :  Child can't allocate >3Gb memory in
>  32bit system
>  min_free_kbytes    0  TINFO  :  set min_free_kbytes to 7588
>  ---- snip ----
> 
> Reported-by: Shuang Qiu <shuang.qiu@oracle.com>
> Signed-off-by: Zhouping Liu <zliu@redhat.com>
> ---
>  testcases/kernel/mem/tunable/min_free_kbytes.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/testcases/kernel/mem/tunable/min_free_kbytes.c
> b/testcases/kernel/mem/tunable/min_free_kbytes.c
> index dde182c..873b807 100644
> --- a/testcases/kernel/mem/tunable/min_free_kbytes.c
> +++ b/testcases/kernel/mem/tunable/min_free_kbytes.c
> @@ -158,8 +158,19 @@ static void test_tune(unsigned long
> overcommit_policy)
>  				    "child unexpectedly failed: %d", status);
>  		} else if (overcommit_policy == 1) {
>  			if (!WIFSIGNALED(status) || WTERMSIG(status) != SIGKILL)
> +#if __WORDSIZE == 32
> +			{
> +				if (total_mem < 3145728UL)
> +#endif
>  				tst_resm(TFAIL,
>  				    "child unexpectedly failed: %d", status);
> +#if __WORDSIZE == 32
> +	/* in 32-bit system, a process allocate about 3Gb memory at most */
> +				else
> +					tst_resm(TINFO, "Child can't allocate "
> +					    ">3Gb memory in 32bit system");
> +			}
> +#endif
>  		} else {
>  			if (WIFEXITED(status)) {
>  				if (WEXITSTATUS(status) != 0) {
> --
> 1.7.11.2
> 
> 

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 3/3] tunable/min_free_kbytes: add 32-bit system limit

[Wanlong Gao]

On 08/31/2012 10:07 AM, Zhouping Liu wrote:
> 
> ----- Original Message -----
>> > From: "Zhouping Liu" <zliu@redhat.com>
>> > To: "LTP list" <ltp-list@lists.sourceforge.net>
>> > Sent: Wednesday, August 29, 2012 8:43:59 PM
>> > Subject: [LTP] [PATCH 3/3] tunable/min_free_kbytes: add 32-bit system limit
>> > 
>> > in 32-bit system, one process only allocate 3Gb memory at
>> > least, even though there are enough memory and setting
> I'm sorry that the above sentences has a typo, 'at least' should be
> changed as 'at most', so maintainers, please correct it if you apply the patch.
> please let me know if you need me send a V2.

This typo is harmless, no need. I wanna know if Caspar like to review this set.

Thanks,
Wanlong Gao

> 
> Thanks,
> Zhouping
> 


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 3/3] tunable/min_free_kbytes: add 32-bit system limit

[Zhouping Liu]

----- Original Message -----
> From: "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
> To: "Zhouping Liu" <zliu@redhat.com>
> Cc: "LTP list" <ltp-list@lists.sourceforge.net>, "Caspar Zhang" <caspar@casparzhang.com>
> Sent: Friday, August 31, 2012 10:11:02 AM
> Subject: Re: [LTP] [PATCH 3/3] tunable/min_free_kbytes: add 32-bit system limit
> 
> On 08/31/2012 10:07 AM, Zhouping Liu wrote:
> > 
> > ----- Original Message -----
> >> > From: "Zhouping Liu" <zliu@redhat.com>
> >> > To: "LTP list" <ltp-list@lists.sourceforge.net>
> >> > Sent: Wednesday, August 29, 2012 8:43:59 PM
> >> > Subject: [LTP] [PATCH 3/3] tunable/min_free_kbytes: add 32-bit
> >> > system limit
> >> > 
> >> > in 32-bit system, one process only allocate 3Gb memory at
> >> > least, even though there are enough memory and setting
> > I'm sorry that the above sentences has a typo, 'at least' should be
> > changed as 'at most', so maintainers, please correct it if you
> > apply the patch.
> > please let me know if you need me send a V2.
> 
> This typo is harmless, no need. I wanna know if Caspar like to review
> this set.

Okay, Thank you for quickly replying :)

> 
> Thanks,
> Wanlong Gao
> 
> > 
> > Thanks,
> > Zhouping
> > 
> 
> 

-- 
Thanks,
Zhouping

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 3/3] tunable/min_free_kbytes: add 32-bit system limit

[Caspar Zhang]

On 08/29/2012 08:43 PM, Zhouping Liu wrote:
> in 32-bit system, one process only allocate 3Gb memory at
> least, even though there are enough memory and setting
> overcommit_memory=1, the porcess always exit when it arrives
> in 3Gb memory.
>
> the patch use '__WORDSIZE' macro to avoid the incorrect 'TFAIL'
> without the patch:
>   ---- snip ----
>   min_free_kbytes    0  TINFO  :  set overcommit_memory to 1
>   min_free_kbytes    0  TINFO  :  set min_free_kbytes to 3794
>   memfree is 15478420 kB before eatup mem
>   memfree is 12333408 kB after eatup mem
>   min_free_kbytes    3  TFAIL  :  child unexpectedly failed: 0
>   min_free_kbytes    0  TINFO  :  set min_free_kbytes to 7588
>   ---- snip ----
>
> after applying the patch:
>   ---- snip ----
>   min_free_kbytes    0  TINFO  :  set overcommit_memory to 1
>   min_free_kbytes    0  TINFO  :  set min_free_kbytes to 3794
>   memfree is 15478420 kB before eatup mem
>   memfree is 12333408 kB after eatup mem
>   min_free_kbytes    0  TINFO  :  Child can't allocate >3Gb memory in 32bit system
>   min_free_kbytes    0  TINFO  :  set min_free_kbytes to 7588
>   ---- snip ----
>
> Reported-by: Shuang Qiu <shuang.qiu@oracle.com>
> Signed-off-by: Zhouping Liu <zliu@redhat.com>

Series Reviewed-by: Caspar Zhang <caspar@casparzhang.com>

> ---
>   testcases/kernel/mem/tunable/min_free_kbytes.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/testcases/kernel/mem/tunable/min_free_kbytes.c b/testcases/kernel/mem/tunable/min_free_kbytes.c
> index dde182c..873b807 100644
> --- a/testcases/kernel/mem/tunable/min_free_kbytes.c
> +++ b/testcases/kernel/mem/tunable/min_free_kbytes.c
> @@ -158,8 +158,19 @@ static void test_tune(unsigned long overcommit_policy)
>   				    "child unexpectedly failed: %d", status);
>   		} else if (overcommit_policy == 1) {
>   			if (!WIFSIGNALED(status) || WTERMSIG(status) != SIGKILL)
> +#if __WORDSIZE == 32
> +			{
> +				if (total_mem < 3145728UL)
> +#endif
>   				tst_resm(TFAIL,
>   				    "child unexpectedly failed: %d", status);
> +#if __WORDSIZE == 32
> +	/* in 32-bit system, a process allocate about 3Gb memory at most */
> +				else
> +					tst_resm(TINFO, "Child can't allocate "
> +					    ">3Gb memory in 32bit system");
> +			}
> +#endif
>   		} else {
>   			if (WIFEXITED(status)) {
>   				if (WEXITSTATUS(status) != 0) {
>


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 3/3] tunable/min_free_kbytes: add 32-bit system limit

[Wanlong Gao]

On 08/31/2012 10:44 AM, Caspar Zhang wrote:
> On 08/29/2012 08:43 PM, Zhouping Liu wrote:
>> > in 32-bit system, one process only allocate 3Gb memory at
>> > least, even though there are enough memory and setting
>> > overcommit_memory=1, the porcess always exit when it arrives
>> > in 3Gb memory.
>> >
>> > the patch use '__WORDSIZE' macro to avoid the incorrect 'TFAIL'
>> > without the patch:
>> >   ---- snip ----
>> >   min_free_kbytes    0  TINFO  :  set overcommit_memory to 1
>> >   min_free_kbytes    0  TINFO  :  set min_free_kbytes to 3794
>> >   memfree is 15478420 kB before eatup mem
>> >   memfree is 12333408 kB after eatup mem
>> >   min_free_kbytes    3  TFAIL  :  child unexpectedly failed: 0
>> >   min_free_kbytes    0  TINFO  :  set min_free_kbytes to 7588
>> >   ---- snip ----
>> >
>> > after applying the patch:
>> >   ---- snip ----
>> >   min_free_kbytes    0  TINFO  :  set overcommit_memory to 1
>> >   min_free_kbytes    0  TINFO  :  set min_free_kbytes to 3794
>> >   memfree is 15478420 kB before eatup mem
>> >   memfree is 12333408 kB after eatup mem
>> >   min_free_kbytes    0  TINFO  :  Child can't allocate >3Gb memory in 32bit system
>> >   min_free_kbytes    0  TINFO  :  set min_free_kbytes to 7588
>> >   ---- snip ----
>> >
>> > Reported-by: Shuang Qiu <shuang.qiu@oracle.com>
>> > Signed-off-by: Zhouping Liu <zliu@redhat.com>
> Series Reviewed-by: Caspar Zhang <caspar@casparzhang.com>
> 

Pushed series, thank you all involved.

Wanlong Gao


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list