From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1T9Qjb-0001lh-GT for ltp-list@lists.sourceforge.net; Thu, 06 Sep 2012 01:18:19 +0000 Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by sog-mx-2.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1T9QjZ-00024n-Jy for ltp-list@lists.sourceforge.net; Thu, 06 Sep 2012 01:18:19 +0000 Message-ID: <5047F9BC.8080809@cn.fujitsu.com> Date: Thu, 06 Sep 2012 09:17:48 +0800 From: Wanlong Gao MIME-Version: 1.0 References: <1346752345-16116-1-git-send-email-kai.kang@windriver.com> In-Reply-To: <1346752345-16116-1-git-send-email-kai.kang@windriver.com> Subject: Re: [LTP] [PATCH] mq_open/16-1: use tmp file to share info Reply-To: gaowanlong@cn.fujitsu.com List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Kang Kai , jstancek@redhat.com Cc: ltp-list@lists.sourceforge.net, Zhenfeng.Zhao@windriver.com On 09/04/2012 05:52 PM, Kang Kai wrote: > In this test case, it uses a variable to share data between child and > parent processes. But after fork there is a copy of the variable in > child process and modify it will not affect the variable in the parent > process. Then when the child process call mq_open() before parent process, > the case will fail. > > Use tmp file to replace the variable. Any modification in child process > can be seen in parent process. Jan, do you have more question about this patch? Kang, can you please rebase the patch against the newest tree? Thanks, Wanlong Gao > > Signed-off-by: Kang Kai > --- > .../conformance/interfaces/mq_open/16-1.c | 40 ++++++++++++++++++-- > 1 files changed, 36 insertions(+), 4 deletions(-) > > diff --git a/testcases/open_posix_testsuite/conformance/interfaces/mq_open/16-1.c b/testcases/open_posix_testsuite/conformance/interfaces/mq_open/16-1.c > index b9a3215..51b954e 100644 > --- a/testcases/open_posix_testsuite/conformance/interfaces/mq_open/16-1.c > +++ b/testcases/open_posix_testsuite/conformance/interfaces/mq_open/16-1.c > @@ -20,9 +20,11 @@ > * this is fine (will have some false positives, but no false negatives). > */ > > +#include > #include > #include > #include > +#include > #include > #include > #include > @@ -32,11 +34,16 @@ > #include "posixtest.h" > > #define NAMESIZE 50 > +#define TNAME "mq_open/16-1.c" > > int main() > { > char qname[NAMESIZE]; > + char fname[NAMESIZE]; > + char buf[NAMESIZE]; > int pid, succeeded=0; > + int fd; > + void *pa = NULL; > mqd_t childqueue, queue; > > /* > @@ -47,6 +54,27 @@ int main() > > sprintf(qname, "/mq_open_16-1_%d", getpid()); > > + sprintf(fname, "/tmp/pts_mq_open_16_1_%d", getpid()); > + unlink(fname); > + fd = open(fname, O_CREAT | O_RDWR | O_EXCL, > + S_IRUSR | S_IWUSR); > + if (fd == -1) { > + printf(TNAME " Error at open(): %s\n", strerror(errno)); > + exit(PTS_UNRESOLVED); > + } > + /* file is empty now, will cause "Bus error" */ > + memset(buf, '\0', NAMESIZE); > + write(fd, buf, sizeof(int)); > + unlink(fname); > + > + pa = mmap(NULL, sizeof(int), PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); > + if (pa == MAP_FAILED) { > + printf(TNAME " Error at mmap: %s\n", strerror(errno)); > + close(fd); > + exit(PTS_FAIL); > + } > + *(int *)pa = 0; > + > if ((pid = fork()) == 0) { > sigset_t mask; > int sig; > @@ -62,7 +90,7 @@ int main() > childqueue = mq_open(qname, O_CREAT|O_EXCL|O_RDWR, > S_IRUSR | S_IWUSR, NULL); > if (childqueue != (mqd_t)-1) { > - succeeded++; > + ++*(int *)pa; > #ifdef DEBUG > printf("mq_open() in child succeeded\n"); > } else { > @@ -79,7 +107,7 @@ int main() > queue = mq_open(qname, O_CREAT | O_EXCL |O_RDWR, > S_IRUSR | S_IWUSR, NULL); > if (queue != (mqd_t)-1) { > - succeeded++; > + ++*(int *)pa; > #ifdef DEBUG > printf("mq_open() in parent succeeded\n"); > } else { > @@ -93,13 +121,15 @@ int main() > mq_close(queue); > mq_close(childqueue); > mq_unlink(qname); > + close(fd); > + munmap(pa, sizeof(int)); > return PTS_UNRESOLVED; > } > > mq_close(queue); > mq_close(childqueue); > mq_unlink(qname); > - > + succeeded = *(int *)pa; > if (succeeded==0) { > printf("Test FAILED - mq_open() never succeeded\n"); > return PTS_FAIL; > @@ -111,8 +141,10 @@ int main() > } > > printf("Test PASSED\n"); > + close(fd); > + munmap(pa, sizeof(int)); > return PTS_PASS; > } > > return PTS_UNRESOLVED; > -} > \ No newline at end of file > +} > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list