From: DAN LI <li.dan@cn.fujitsu.com>
To: LTP list <ltp-list@lists.sourceforge.net>
Subject: [LTP] [PATCH] bind/03, 21 rbind/38, 33:fix missing umount and error umount in these cases
Date: Thu, 13 Sep 2012 09:26:04 +0800 [thread overview]
Message-ID: <5051362C.8070402@cn.fujitsu.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
The cases have the same problem that dirs are still in mount when their
targets are removed.for rbind/38,beside the problem above,there are two
error umount operations that umount dirs that are not in mount.
and all these result in making the test script trapped in a infinite loop.
To resolve these problems,all we need is just umount the mountpoints before
their targets are removed and delete the error umount operations.
[-- Attachment #2: 0001-fix-BindMounts-problems.patch --]
[-- Type: text/x-patch, Size: 1806 bytes --]
Signed-off-by: DAN LI <li.dan@cn.fujitsu.com>
---
testcases/kernel/fs/fs_bind/bind/test03 | 1 +
testcases/kernel/fs/fs_bind/bind/test21 | 1 +
testcases/kernel/fs/fs_bind/rbind/test33 | 1 +
testcases/kernel/fs/fs_bind/rbind/test38 | 5 ++---
4 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/testcases/kernel/fs/fs_bind/bind/test03 b/testcases/kernel/fs/fs_bind/bind/test03
index 10b678a..5989a3a 100755
--- a/testcases/kernel/fs/fs_bind/bind/test03
+++ b/testcases/kernel/fs/fs_bind/bind/test03
@@ -98,6 +98,7 @@ trap '' ERR
umount share2
umount share2
umount parent1
+ umount parent2
rm -rf parent* share*
cleanup
diff --git a/testcases/kernel/fs/fs_bind/bind/test21 b/testcases/kernel/fs/fs_bind/bind/test21
index 741161f..ab0bf88 100755
--- a/testcases/kernel/fs/fs_bind/bind/test21
+++ b/testcases/kernel/fs/fs_bind/bind/test21
@@ -93,6 +93,7 @@ trap '' ERR
umount dir1
umount dir2
umount dir3
+ umount dir4
rm -rf dir*
diff --git a/testcases/kernel/fs/fs_bind/rbind/test33 b/testcases/kernel/fs/fs_bind/rbind/test33
index 8247747..9ccc53b 100755
--- a/testcases/kernel/fs/fs_bind/rbind/test33
+++ b/testcases/kernel/fs/fs_bind/rbind/test33
@@ -93,6 +93,7 @@ trap '' ERR
umount dir1
umount dir2
umount dir3
+ umount dir4
rm -rf dir*
diff --git a/testcases/kernel/fs/fs_bind/rbind/test38 b/testcases/kernel/fs/fs_bind/rbind/test38
index c06f072..c3f46fb 100755
--- a/testcases/kernel/fs/fs_bind/rbind/test38
+++ b/testcases/kernel/fs/fs_bind/rbind/test38
@@ -82,11 +82,10 @@ trap '' ERR
umount parent1/child1
umount parent2/child1
umount parent2/child1
- umount parent2
+ umount parent2/child2
+ umount parent2
umount share1
umount share1
- umount share2
- umount share2
rm -rf parent* share*
cleanup
--
1.7.1
[-- Attachment #3: Type: text/plain, Size: 395 bytes --]
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next reply other threads:[~2012-09-13 1:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 1:26 DAN LI [this message]
2012-09-18 7:20 ` [LTP] [PATCH] bind/03, 21 rbind/38, 33:fix missing umount and error umount in these cases Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5051362C.8070402@cn.fujitsu.com \
--to=li.dan@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox