public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Chris Dearman <chris@mips.com>
To: ltp-list@lists.sourceforge.net
Cc: Chris Dearman <chris@mips.com>
Subject: [LTP] [PATCH] Avoid compiler optimisation of malloc calls
Date: Tue, 16 Oct 2012 07:17:07 -0700	[thread overview]
Message-ID: <507D6C63.5040704@mips.com> (raw)

clang understands the malloc library call and can optimise calls to
it. In particular it will avoid calling malloc completely if it
detects that the result is not used.

Signed-off-by: Chris Dearman <chris@mips.com>
---
  .../conformance/interfaces/pthread_cond_init/4-1.c |   19 
++++++++++++-------
  1 files changed, 12 insertions(+), 7 deletions(-)

diff --git 
a/testcases/open_posix_testsuite/conformance/interfaces/pthread_cond_init/4-1.c 
b/testcases/open_posix_testsuite/conformance/interfaces/pthread_cond_init/4-1.c
index 287fda1..7932ec2 100644
--- 
a/testcases/open_posix_testsuite/conformance/interfaces/pthread_cond_init/4-1.c
+++ 
b/testcases/open_posix_testsuite/conformance/interfaces/pthread_cond_init/4-1.c
@@ -50,7 +50,7 @@
  #define ERR_MSG(f, rc) printf("Failed: func: %s rc: %s (%u)\n", \
  			f, strerror(rc), rc);
  -/* Max memory for child is 81B */
+/* Max memory for child is 1MB */
  #define MAX_MEM	((1<<20))
   /*
@@ -59,8 +59,8 @@
   */
  static void child(void)
  {
-	char *curr;
-	char *prev = NULL;
+	void *curr;
+	void *prev = NULL;
  	struct rlimit rl;
  	pthread_cond_t cond;
  	pthread_condattr_t attr;
@@ -76,10 +76,15 @@ static void child(void)
  		exit(PTS_UNRESOLVED);
  	}
  -	/* Consume all memory we can */
-	do {
-		curr = malloc(1);
-	} while (curr);
+	/*
+	 * Consume all memory we can
+	 * It's important to use the malloc() return value in a
+	 * meaningful way to bypass potential compiler optimisations.
+	 */
+	while ((curr = malloc(sizeof(void *)))) {
+		*(void **)curr = prev;
+		prev = curr;
+	}
  	if (errno != ENOMEM) {
  		ERR_MSG("malloc()", errno);
  		exit(PTS_UNRESOLVED);
-- 
1.7.1


------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

             reply	other threads:[~2012-10-16 14:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16 14:17 Chris Dearman [this message]
2012-10-17 16:04 ` [LTP] [PATCH] Avoid compiler optimisation of malloc calls chrubis
2012-10-17 17:35 ` Chris Dearman
2012-10-18  1:36   ` Wanlong Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507D6C63.5040704@mips.com \
    --to=chris@mips.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox