[LTP] [PATCH 5/6] creat07: no need to pass tst_ipc_envp anymore

Jan Stancek
2017-10-12T09:34:20Z

----- Original Message -----
> From: "Jan Stancek" <jstancek@redhat.com>
> To: "Cyril Hrubis" <chrubis@suse.cz>
> Cc: ltp@lists.linux.it
> Sent: Thursday, 12 October, 2017 10:50:32 AM
> Subject: Re: [LTP] [PATCH 5/6] creat07: no need to pass tst_ipc_envp anymore
>
>
> ----- Original Message -----
> > Hi!
> > > Signed-off-by: Jan Stancek <jstancek@redhat.com>
> > > ---
> > > testcases/kernel/syscalls/creat/creat07.c | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/testcases/kernel/syscalls/creat/creat07.c
> > > b/testcases/kernel/syscalls/creat/creat07.c
> > > index e1b267661c39..236f4edf843f 100644
> > > --- a/testcases/kernel/syscalls/creat/creat07.c
> > > +++ b/testcases/kernel/syscalls/creat/creat07.c
> > > @@ -38,9 +38,7 @@ static void verify_creat(void)
> > >
> > > pid = SAFE_FORK();
> > > if (pid == 0) {
> > > - char *av[] = {TEST_APP, NULL};
> > > - (void)execve(TEST_APP, av, tst_ipc_envp);
> > > - perror("execve failed");
> > > + SAFE_EXECLP(TEST_APP, TEST_APP, NULL);
> >
> > And it looks like this broke the test when executed from installed LTP,
> > that is because the execlp() picks up the TEST_APP from
> > /opt/ltp/testcasese/bin/ instead of the local copy. I guess that we have
> > to use exec() variant without the p at the end here.
>
> Or we can switch order so that "." is searched as first:
> SAFE_ASPRINTF(&new_path, ":%s:%s", start_dir, old_path);
> What do you think?

I pushed Li's version, while this is being discussed.

Regards,
Jan