From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Simon Xu <xu.simon@oracle.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] numa01.sh: fix error in getting number of CPUs
Date: Fri, 23 Nov 2012 15:04:10 +0800 [thread overview]
Message-ID: <50AF1FEA.9000602@cn.fujitsu.com> (raw)
In-Reply-To: <50AF0EE3.1080904@oracle.com>
On 11/23/2012 01:51 PM, Simon Xu wrote:
> On 2012/11/23 13:46, Wanlong Gao wrote:
>> On 11/23/2012 01:42 PM, Simon Xu wrote:
>>> test04 in numa01.sh is using a wrong method to get the number of CPUs.
>>> This results in:
>>>
>>> numactl: cpu argument 9 is out of range
>>>
>>> awk: cmd. line:1: fatal: cannot open file `/proc/4116/stat' for reading
>>> (No such file or directory)
>>> /opt/ltp/testcases/bin/numa01.sh: line 475: [: =: unary operator expected
>>> awk: cmd. line:1: fatal: cannot open file `/proc/4116/stat' for reading
>>> (No such file or directory)
>>> /opt/ltp/testcases/bin/numa01.sh: line 481: [: -ne: unary operator expected
>>> /opt/ltp/testcases/bin/numa01.sh: line 488: kill: (4116) - No such process
>>> numa04 4 TBROK : Kill on process 4116 fails
>>>
>>> Fix it by getting number of CPUs by grepping /proc/cpuinfo.
>>> ---
>>> testcases/kernel/numa/numa01.sh | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/testcases/kernel/numa/numa01.sh b/testcases/kernel/numa/numa01.sh
>>> index 3ea7950..8d0808a 100644
>>> --- a/testcases/kernel/numa/numa01.sh
>>> +++ b/testcases/kernel/numa/numa01.sh
>>> @@ -466,7 +466,7 @@ test04()
>>> run_on_cpu=0
>>> running_on_cpu=0
>>> - no_of_cpus=$(ls /sys/devices/system/cpu/ | wc -w)
>>> + no_of_cpus=$(grep "^processor" /proc/cpuinfo | wc -l)
>> We have commands tst_ncpus and tst_ncpus_max to get the number of cpu in the system.
>
> That's fine. Please fix this issue the LTP way.
Thank you, I made a patch to fix this, please refer to: https://github.com/linux-test-project/ltp/commit/9b87d9c5678ad3dc2cf561774c7a1c6a16388935
Wanlong Gao
>
> Thanks
> Simon
>
>>> # not sure whether cpu's can't be in odd number
>>> run_on_cpu=$[$[$no_of_cpus+1]/2]
>>> numactl --physcpubind=$run_on_cpu support_numa $PAUSE & #just waits for sigint
>
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2012-11-23 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 5:42 [LTP] [PATCH] numa01.sh: fix error in getting number of CPUs Simon Xu
2012-11-23 5:46 ` Wanlong Gao
2012-11-23 5:51 ` Simon Xu
2012-11-23 7:04 ` Wanlong Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AF1FEA.9000602@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=xu.simon@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox